Add proxy startup and liveness probe config. #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komapa
reviewed
Jan 9, 2024
control-plane/connect-inject/webhook/consul_dataplane_sidecar.go
Outdated
Show resolved
Hide resolved
hashi-derek
force-pushed
the
derekm/NET-6858/failure-probe-config
branch
from
a2a3912
to
1c9d2c7
Compare
hashi-derek
requested review from
a team,
david-yu and
wilkermichael
and removed request for
a team
david-yu
approved these changes
Jan 9, 2024
wilkermichael
approved these changes
Jan 9, 2024
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
force-pushed
the
derekm/NET-6858/failure-probe-config
branch
from
1c9d2c7
to
f80723a
Compare
hashi-derek
added
backport/1.1.x
hashi-derek
added a commit
that referenced
this pull request
Jan 11, 2024
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
added a commit
that referenced
this pull request
Jan 11, 2024
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
added a commit
that referenced
this pull request
Jan 12, 2024
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
added a commit
that referenced
this pull request
Jan 12, 2024
This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
hashi-derek
added a commit
that referenced
this pull request
Jan 12, 2024
…/1.2.x (#3468) Add proxy startup and liveness probe config. (#3450) This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover. Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
hashi-derek
added a commit
that referenced
this pull request
Jan 12, 2024
…/1.1.x (#3467) * Add proxy startup and liveness probe config. (#3450) This PR adds in two new `consul.hashicorp.com/sidecar-proxy-startup-failure-seconds` and `consul.hashicorp.com/sidecar-proxy-liveness-failure-seconds` annotations that are disabled by default. When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover. * Fix potential test deadlock. --------- Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com> Co-authored-by: Derek Menteer <derek.menteer@hashicorp.com>
This was referenced Jan 16, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in two new
consul.hashicorp.com/sidecar-proxy-startup-failure-secondsandconsul.hashicorp.com/sidecar-proxy-liveness-failure-secondsannotations that are disabled by default.When set to a value greater than zero, these configurations will enable their corresponding startup / liveness probes for the Envoy proxy. This helps to prevent scenarios where the Envoy proxy would hang and never recover.
Due to the difficult nature of testing this particular scenario, manual testing was performed on modified consul-server code to ensure that the probes would trigger a restart of the consul-dataplane container when unhealthy.