Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for k8s liveness / startup probes. #20213

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

hashi-derek
Copy link
Member

Docs changes for: hashicorp/consul-k8s#3450

@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Jan 16, 2024
@hashi-derek hashi-derek added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jan 16, 2024
@hashi-derek hashi-derek marked this pull request as ready for review January 16, 2024 15:05
@hashi-derek hashi-derek requested a review from a team as a code owner January 16, 2024 15:05
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

Just some minor style guide suggestions.

Approving on behalf of consul-docs.

website/content/docs/k8s/helm.mdx Outdated Show resolved Hide resolved
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
@hashi-derek hashi-derek merged commit 1d396ba into main Jan 16, 2024
92 checks passed
@hashi-derek hashi-derek deleted the derekm/NET-6858/add-docs branch January 16, 2024 21:09
hashi-derek added a commit that referenced this pull request Jan 16, 2024
* Add docs for k8s liveness / startup probes.

* Update website/content/docs/k8s/helm.mdx

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>

---------

Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
hashi-derek added a commit that referenced this pull request Jan 16, 2024
…1.15.x (#20225)

Add docs for k8s liveness / startup probes. (#20213)

* Add docs for k8s liveness / startup probes.

* Update website/content/docs/k8s/helm.mdx



---------

Co-authored-by: Derek Menteer <105233703+hashi-derek@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants