-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ACL support for health checks controller #368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
added
type/enhancement
New feature or request
area/acls
Related to ACLs
theme/health-checks
About Consul health checking
labels
Oct 27, 2020
kschoche
requested review from
lkysow and
ishustava
and removed request for
a team
October 27, 2020 14:09
kschoche
commented
Oct 27, 2020
kschoche
commented
Oct 27, 2020
kschoche
commented
Oct 27, 2020
kschoche
commented
Oct 27, 2020
* Use tt when t.Parallel() is used.
lkysow
reviewed
Oct 30, 2020
lkysow
reviewed
Oct 30, 2020
lkysow
reviewed
Oct 30, 2020
lkysow
approved these changes
Oct 30, 2020
ishustava
approved these changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've added some comments and suggestions, but I don't think they are blocking the merge.
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
1 task
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Support ACL replication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/acls
Related to ACLs
theme/health-checks
About Consul health checking
type/enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
-create-inject-auth-method
-create-inject-namespace-token
. This flag was always passed when-enable-namespaces
was true so now we just look at-enable-namespaces
and-create-inject-token
-create-inject-token
. This will always be passed by helm if connect inject is enabled.-create-inject-namespace-token
from oss to ent as these are now invalid for oss (they always were but they got away with being in oss because they weren't passing-enable-namespaces
How I've tested this PR:
unit tests + some manual testing of the command flags
How I expect reviewers to test this PR:
run the unit tests and try out the full stack by grabbing
hashicorp/consul-helm#665
This table summarizes what helm would pass with versions <= 0.25.0 (old) and > 0.25.0 (new):
Checklist: