Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-10961] Ignore gke managed namespaces by default into release/1.4.x #4349

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #4333 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "0aaf003e3c05372cdc360d347638849949623366", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Changes proposed in this PR

  • on GKE we should not attempt to inject pods in a gke managed namespaces because many of them do not have a corresponding k8s service which causes the connect injector container to crash and send those pods into an infinite crash loop

How I've tested this PR

  • deployed gke cluster with consul using this helm chart update, the containers in the gke managed namespaces were no longer crashing after this change

How I expect reviewers to test this PR

Follow the instructions in the README for this repo: https://github.com/jm96441n/consul-experiments/tree/main/k8s/gke-ns

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-10961-exclude-gke-namespaces-from-connect-inject/genuinely-natural-redbird branch from 67e908f to 2bdd21e Compare September 19, 2024 19:32
@NiniOak NiniOak assigned jm96441n and unassigned NiniOak Sep 19, 2024
@jm96441n jm96441n marked this pull request as ready for review September 20, 2024 17:47
@jm96441n jm96441n enabled auto-merge (squash) September 20, 2024 17:50
@jm96441n jm96441n merged commit 0ad1edd into release/1.4.x Sep 20, 2024
49 of 50 checks passed
@jm96441n jm96441n deleted the backport/NET-10961-exclude-gke-namespaces-from-connect-inject/genuinely-natural-redbird branch September 20, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants