Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [NET-10961] Ignore gke managed namespaces by default into release/1.4.x #4349

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Backport of [NET-10961] Ignore gke managed namespaces by default into release/1.4.x #4349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e279e3f
backport of commit 79f171bfedc5f3f2b73638e174258f5e7063f78a
jm96441n Sep 6, 2024
2bdd21e
backport of commit 7d2782ec1673d57fcdb17ba123e8e18c82d14171
jm96441n Sep 17, 2024
4173619
remove spaces
jm96441n Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/4333.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
helm: Exclude gke namespaces from being connect-injected when the connect-inject: default: true value is set.
```
3 changes: 2 additions & 1 deletion charts/consul/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2733,6 +2733,7 @@ connectInject:
# By default, we exclude kube-system since usually users won't
# want those pods injected and local-path-storage and openebs so that
# Kind (Kubernetes In Docker) and [OpenEBS](https://openebs.io/) respectively can provision Pods used to create PVCs.
# We also exclude gmp-system and gke-managed-cim namespaces that are used by GKE for managing the cluster.
# Note that this exclusion is only supported in Kubernetes v1.21.1+.
#
# Example:
Expand All @@ -2747,7 +2748,7 @@ connectInject:
matchExpressions:
- key: "kubernetes.io/metadata.name"
operator: "NotIn"
values: ["kube-system","local-path-storage","openebs"]
values: ["kube-system","local-path-storage","openebs","gmp-system","gke-managed-cim"]

# List of k8s namespaces to allow Connect sidecar
# injection in. If a k8s namespace is not included or is listed in `k8sDenyNamespaces`,
Expand Down
Loading