Do not mount consul-ca-cert to partition init if externalServers.useSystemRoots is true #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
lkysow,
a team and
ndhanushkodi
and removed request for
a team
added 2 commits
November 30, 2021 14:07
externalServers.useSystemRoots is true
thisisnotashwin
force-pushed
the
partition-init-system-rootsx
branch
from
7bd575b to
3996a05
Compare
lkysow
reviewed
Nov 30, 2021
lkysow
approved these changes
Dec 1, 2021
thisisnotashwin
force-pushed
the
partition-init-system-rootsx
branch
from
ec91c64 to
691fe82
Compare
rrondeau
pushed a commit
to rrondeau/consul-k8s
that referenced
this pull request
Dec 21, 2021
* Give time for injector to come up Getting certificates can take a couple of seconds causing the liveness probes to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I've tested this PR: Compared code to using
useSystemRootsacross the project. Unit tests.How I expect reviewers to test this PR: 👀
Checklist: