Skip to content

Commit

Permalink
Give time for injector to come up (hashicorp#885)
Browse files Browse the repository at this point in the history
* Give time for injector to come up

Getting certificates can take a couple of seconds causing the liveness probes to fail
  • Loading branch information
lkysow authored Mar 30, 2021
1 parent 86a91e1 commit 6bac7c4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ IMPROVEMENTS:
BREAKING CHANGES:
* Minimum Kubernetes versions supported is 1.16+. [[GH-883](https://github.com/hashicorp/consul-helm/pull/883)]

BUG FIXES:
* Add startup probe to connect-inject deployment to give time for certificates to be available.
Previously, the deployment could be killed by Kubernetes and crash loop because certificates would take a couple
of seconds. [[GH-885](https://github.com/hashicorp/consul-helm/pull/885)]

## 0.31.1 (Mar 19, 2021)

BUG FIXES:
Expand Down
8 changes: 8 additions & 0 deletions templates/connect-inject-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,14 @@ spec:
periodSeconds: 2
successThreshold: 1
timeoutSeconds: 5
startupProbe:
httpGet:
path: /health/ready
port: 8080
scheme: HTTPS
failureThreshold: 15
periodSeconds: 2
timeoutSeconds: 5
{{- if (or .Values.connectInject.certs.secretName .Values.global.tls.enabled) }}
volumeMounts:
{{- if .Values.connectInject.certs.secretName }}
Expand Down

0 comments on commit 6bac7c4

Please sign in to comment.