-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Kind to ApiVersion #923
Conversation
Hi @mvnarsing Could you tell us what K8s version and what distribution of K8s you are running? |
K8s version --> 1.20.9 |
@david-yu Please let me know if you need any additional details for this PR and next steps, I already signed the CLA but still showing as pending here |
@david-yu , any further details you need or any update you have for this PR? |
@david-yu Please acknowledge this message and let us know if anyone is reviewing it or need additional details? |
Hi @mvnarsing we've been out due to the holidays but I've noted that we should review this PR and get back to you. |
Hey @mvnarsing Thanks for this fix. I think this change looks good but would mind signing the CLA and fixing/changing the unit tests? |
Thank you for your update, I did sign the CLA but for some reason its still showing up as pending. Attached screenshot which says I signed the CLA |
@mvnarsing Thank you! Reading the error message about the CLA, I'm wondering if it's failing because your git user on the commits is different from the user on this PR? If you change the author on the commits, that might be able to fix it. |
@ishustava I was able to update my author info to get CLA signed and now its all green, please let me know if you need any additional details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@ishustava @david-yu Any update on when next release will be published with this fix |
@mvnarsing we're cutting the release today 🎉 |
Changes proposed in this PR:
New version of consul helm chart is using apiVersion of "policy/v1" and deprecated "v1beata1" causing errors similar to below issues with cortex and argocd. Used the workaround mentioned to use Kind with apiVersion and that works.
cortexproject/cortex-helm-chart#277
argoproj/argo-cd#7291
How I've tested this PR:
Tested locally against the new version of consul 1.10.4 with helm chart 0.37.0 and had issues with PBD not syncing up in argocd and complaining about apiversion.
How I expect reviewers to test this PR:
Create a release version and test it.
Checklist: