Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Kind to ApiVersion #923

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Conversation

mvnarsing
Copy link
Contributor

Changes proposed in this PR:
New version of consul helm chart is using apiVersion of "policy/v1" and deprecated "v1beata1" causing errors similar to below issues with cortex and argocd. Used the workaround mentioned to use Kind with apiVersion and that works.
cortexproject/cortex-helm-chart#277
argoproj/argo-cd#7291

How I've tested this PR:
Tested locally against the new version of consul 1.10.4 with helm chart 0.37.0 and had issues with PBD not syncing up in argocd and complaining about apiversion.

How I expect reviewers to test this PR:
Create a release version and test it.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 10, 2021

CLA assistant check
All committers have signed the CLA.

@david-yu
Copy link
Contributor

Hi @mvnarsing Could you tell us what K8s version and what distribution of K8s you are running?

@mvnarsing
Copy link
Contributor Author

mvnarsing commented Dec 14, 2021

Could you tell us what K8s version and what distribution of K8s you are running?

K8s version --> 1.20.9
Azure AKS

@mvnarsing
Copy link
Contributor Author

Hi @mvnarsing Could you tell us what K8s version and what distribution of K8s you are running?

@david-yu Please let me know if you need any additional details for this PR and next steps, I already signed the CLA but still showing as pending here

@mvnarsing
Copy link
Contributor Author

mvnarsing commented Dec 21, 2021

@david-yu , any further details you need or any update you have for this PR?

@mvnarsing
Copy link
Contributor Author

Hi @mvnarsing Could you tell us what K8s version and what distribution of K8s you are running?

@david-yu Please acknowledge this message and let us know if anyone is reviewing it or need additional details?

@david-yu
Copy link
Contributor

david-yu commented Jan 5, 2022

Hi @mvnarsing we've been out due to the holidays but I've noted that we should review this PR and get back to you.

@ishustava
Copy link
Contributor

Hey @mvnarsing

Thanks for this fix.

I think this change looks good but would mind signing the CLA and fixing/changing the unit tests?

@ishustava ishustava added the waiting-reply Waiting on the issue creator for a response before taking further action label Jan 5, 2022
@mvnarsing
Copy link
Contributor Author

Hey @mvnarsing

Thanks for this fix.

I think this change looks good but would mind signing the CLA and fixing/changing the unit tests?

Thank you for your update, I did sign the CLA but for some reason its still showing up as pending. Attached screenshot which says I signed the CLA
Screen Shot 2022-01-05 at 5 16 24 PM

@ishustava
Copy link
Contributor

Thank you for your update, I did sign the CLA but for some reason its still showing up as pending. Attached screenshot which says I signed the CLA

@mvnarsing Thank you! Reading the error message about the CLA, I'm wondering if it's failing because your git user on the commits is different from the user on this PR? If you change the author on the commits, that might be able to fix it.

@mvnarsing
Copy link
Contributor Author

Thank you for your update, I did sign the CLA but for some reason its still showing up as pending. Attached screenshot which says I signed the CLA

@mvnarsing Thank you! Reading the error message about the CLA, I'm wondering if it's failing because your git user on the commits is different from the user on this PR? If you change the author on the commits, that might be able to fix it.

@ishustava I was able to update my author info to get CLA signed and now its all green, please let me know if you need any additional details

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ishustava ishustava removed the waiting-reply Waiting on the issue creator for a response before taking further action label Jan 10, 2022
@ishustava ishustava merged commit 6e70d2d into hashicorp:main Jan 10, 2022
ishustava added a commit that referenced this pull request Jan 13, 2022
@mvnarsing
Copy link
Contributor Author

Looks great!

@ishustava @david-yu Any update on when next release will be published with this fix

@ishustava
Copy link
Contributor

@mvnarsing we're cutting the release today 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants