Skip to content

Commit

Permalink
Merge pull request #10149 from hashicorp/dnephin/config-use-streaming…
Browse files Browse the repository at this point in the history
…-backend-defualt-true

config: default UseStreamingBackend to true
  • Loading branch information
dnephin authored Apr 30, 2021
2 parents 0f8cdfa + 5a87b8a commit 00d3283
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .changelog/10149.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
streaming: change `use_streaming_backend` to default to true so that streaming is used by default when it is supported.
```
2 changes: 1 addition & 1 deletion agent/config/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ func (b *builder) Build() (rt RuntimeConfig, err error) {
Watches: c.Watches,
}

rt.UseStreamingBackend = boolVal(c.UseStreamingBackend)
rt.UseStreamingBackend = boolValWithDefault(c.UseStreamingBackend, true)

if rt.Cache.EntryFetchMaxBurst <= 0 {
return RuntimeConfig{}, fmt.Errorf("cache.entry_fetch_max_burst must be strictly positive, was: %v", rt.Cache.EntryFetchMaxBurst)
Expand Down
6 changes: 1 addition & 5 deletions website/content/docs/agent/options.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -2208,14 +2208,10 @@ bind_addr = "{{ GetPrivateInterfaces | include \"network\" \"10.0.0.0/8\" | attr
currently only supports numeric IDs.
- `mode` - The permission bits to set on the file.

- `use_streaming_backend` (experimental) when enabled Consul client agents will use
- `use_streaming_backend` defaults to true. When enabled Consul client agents will use
streaming rpc, instead of the traditional blocking queries, for endpoints which support
streaming. All servers must have [`rpc.enable_streaming`](#rpc_enable_streaming)
enabled before any client can enable `use_streaming_backend`.
At least one of [`dns_config.use_cache`](#dns_use_cache) or
[`http_config.use_cache`](#http_config_use_cache) must be enabled, otherwise
this setting has no effect.
`use_streaming_backend` will default to true in a future version of Consul.

- `verify_incoming` - If set to true, Consul
requires that all incoming connections make use of TLS and that the client
Expand Down

0 comments on commit 00d3283

Please sign in to comment.