Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: default UseStreamingBackend to true #10149

Merged
merged 2 commits into from
Apr 30, 2021
Merged

config: default UseStreamingBackend to true #10149

merged 2 commits into from
Apr 30, 2021

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Apr 28, 2021 •
edited
Loading

Enable use_streaming_backend by default.

I'll make the rest of the docs changes in a separate PR.

@dnephin dnephin added the theme/streaming Related to Streaming connections between server and client label Apr 28, 2021
@github-actions github-actions bot added theme/config Relating to Consul Agent configuration, including reloading type/docs Documentation needs to be created/updated/clarified labels Apr 28, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul April 29, 2021 17:32 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 29, 2021 17:32 Inactive
@dnephin dnephin requested a review from a team April 29, 2021 17:32
@dnephin dnephin marked this pull request as ready for review April 29, 2021 17:32
@dnephin dnephin added this to the 1.10.0 milestone Apr 29, 2021
@dnephin dnephin modified the milestones: 1.10.0, 1.10.0-beta2 Apr 29, 2021
@dnephin dnephin merged commit 00d3283 into master Apr 30, 2021
@dnephin dnephin deleted the dnephin/config-use-streaming-backend-defualt-true branch April 30, 2021 20:29
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/360634.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit 00d3283 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 30, 2021
@dnephin @hc-github-team-consul-core
Merge pull request #10149 from hashicorp/dnephin/config-use-streaming…
ac2aeb8 
…-backend-defualt-true

config: default UseStreamingBackend to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyhavlov kyhavlov kyhavlov approved these changes

Assignees
No one assigned
Labels
theme/config Relating to Consul Agent configuration, including reloading theme/streaming Related to Streaming connections between server and client type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
1.10.0-beta2
Development

Successfully merging this pull request may close these issues.
4 participants
@dnephin @hashicorp-ci @hc-github-team-consul-core @kyhavlov