Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for KV DeleteKey operation seems incomplete #7385

Closed
abidon opened this issue Mar 4, 2020 · 0 comments · Fixed by #8135
Closed

Documentation for KV DeleteKey operation seems incomplete #7385

abidon opened this issue Mar 4, 2020 · 0 comments · Fixed by #8135
Labels
type/docs Documentation needs to be created/updated/clarified

Comments

@abidon
Copy link

abidon commented Mar 4, 2020

Overview of the Issue

Documentation for the "Delete Key" operation in KV does not document the dc parameter.
Yet, when I try to do a request with the dc parameter, it seems to take it in account, so it seems to be a documentation typo.

Reproduction Steps

  1. Run curl -X DELETE localhost:8500/v1/kv/foo?dc=some-factice-datacenter
    The output is: No path to datacenter which is expected, but not documented.
@jsosulska jsosulska added the type/docs Documentation needs to be created/updated/clarified label Mar 5, 2020
jsosulska added a commit that referenced this issue Jun 17, 2020
@jsosulska
Fixes #7385 - Document KV Delete DC
003bbfd
@jsosulska jsosulska mentioned this issue Jun 17, 2020
Merged
jsosulska added a commit that referenced this issue Jun 18, 2020
@jsosulska @freddygv
Fixing multiple document updates (#8135)
c8bee5a 
* Fixes #7663-ACL Token Reloadable#7432-Cipher Suites,#7385-KV Delete DC, raft list-peers docs

Co-authored-by: Freddy <freddygv@users.noreply.github.com>
hashicorp-ci pushed a commit that referenced this issue Jun 18, 2020
@jsosulska @freddygv @hashicorp-ci
Fixing multiple document updates (#8135)
672a161 
* Fixes #7663-ACL Token Reloadable#7432-Cipher Suites,#7385-KV Delete DC, raft list-peers docs

Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing multiple document updates hashicorp/consul
2 participants
@abidon @jsosulska