Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ACL tokens to be "Reloadable Configuration" #7663

Closed
jsmilani opened this issue Apr 17, 2020 · 3 comments · Fixed by #8135
Closed

Allow ACL tokens to be "Reloadable Configuration" #7663

jsmilani opened this issue Apr 17, 2020 · 3 comments · Fixed by #8135
Assignees
Labels
theme/consul-vault Relating to Consul & Vault interactions type/docs Documentation needs to be created/updated/clarified

Comments

@jsmilani
Copy link

There seems to be a contradiction in the Vault best practices when using the Consul Secrets Engine and the fact that Consul doesn't allow reloading of tokens (https://www.consul.io/docs/agent/options.html#reloadable-configuration). Since you cannot just trigger a reload, you must restart the Consul process. Restarts of a consul server on an HA cluster may not be that bad but restarts of clients running on individual hosts where there is only one instance causes momentary outages.

Feature Description

We request that all the tokens in the ACL section of the config be part of Reloadable Configuration.

Use Case(s)

We have compliance requirements to rotate passwords and tokens periodically and Vault is perfect for that. The problem is when implementing a rotating Consul token, the tokens don't get reloaded with the HUP signal so Consul must be restarted which causes short downtime when using it for service discovery or as a KV datastore, etc.

@mkeeler
Copy link
Member

mkeeler commented Apr 17, 2020

@jsmilani This feature was actually added in v1.4.3 (#5328) but apparently the docs didn't get updated.

@mkeeler mkeeler added the type/docs Documentation needs to be created/updated/clarified label Apr 17, 2020
@jsmilani
Copy link
Author

I ended up coming to the same conclusion. We are trying to explain why consul-template isn't renewing consul tokens and this seemed like the most logical reason given the information in the docs. Now we have to look elsewhere for the cause of the problem.

That is good to hear. Can this issue address updating the docs or do I need to create an issue somewhere else?

@jsosulska
Copy link
Contributor

Hi @jsmilani

We'll go ahead and use this issue to track the documentation updates. Thank you for reporting it.

@jsosulska jsosulska self-assigned this May 7, 2020
@jsosulska jsosulska added the theme/consul-vault Relating to Consul & Vault interactions label Jun 1, 2020
jsosulska added a commit that referenced this issue Jun 16, 2020
jsosulska added a commit that referenced this issue Jun 18, 2020
* Fixes #7663-ACL Token Reloadable#7432-Cipher Suites,#7385-KV Delete DC, raft list-peers docs

Co-authored-by: Freddy <freddygv@users.noreply.github.com>
hashicorp-ci pushed a commit that referenced this issue Jun 18, 2020
* Fixes #7663-ACL Token Reloadable#7432-Cipher Suites,#7385-KV Delete DC, raft list-peers docs

Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/consul-vault Relating to Consul & Vault interactions type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants