Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for tls_cipher_suites #11070

Merged
merged 2 commits into from
Oct 21, 2021
Merged

Update docs for tls_cipher_suites #11070

merged 2 commits into from
Oct 21, 2021

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Sep 16, 2021

Go 1.17 will change the behaviour of some TLS configs [link].

This commit updates the docs to clarify existing behaviour and warn of potential future changes.

@kisunji kisunji requested a review from a team as a code owner September 16, 2021 20:30
@kisunji kisunji requested a review from a team September 16, 2021 20:30
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 16, 2021
@kisunji kisunji added pr/no-changelog PR does not need a corresponding .changelog entry and removed type/docs Documentation needs to be created/updated/clarified labels Sep 16, 2021
@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging September 16, 2021 20:31 Inactive
@rboyer
Copy link
Member

rboyer commented Sep 16, 2021

I feel like this should wait until we change the build to use Go 1.17+

@kisunji
Copy link
Contributor Author

kisunji commented Sep 16, 2021

I feel like this should wait until we change the build to use Go 1.17+

It's technically a breaking change so I wanted to put out a warning before we make the transition, but the actual impact might be negligible! I'm find with holding off on the PR

trujillo-adam
trujillo-adam approved these changes Sep 21, 2021
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good.

dnephin
dnephin reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but if we do indeed change to Go 1.17 in the next release I guess we'll want to change these notes from saying "in the future" to "In Consul 1.11".

@dnephin dnephin mentioned this pull request Oct 20, 2021
Merged
3 tasks
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 15:54 Inactive
dnephin
dnephin approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kisunji kisunji merged commit c0991f4 into main Oct 21, 2021
@kisunji kisunji deleted the kisunji/cipher-suites-update branch October 21, 2021 20:41
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481951.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit c0991f4 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Oct 21, 2021
@hc-github-team-consul-core
Update docs for tls_cipher_suites (#11070)
90031f2
hc-github-team-consul-core pushed a commit that referenced this pull request Oct 21, 2021
@hc-github-team-consul-core
Update docs for tls_cipher_suites (#11070)
ff49638
@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit c0991f4 onto release/1.10.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

@trujillo-adam trujillo-adam trujillo-adam approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kisunji @hashicorp-ci @rboyer @hc-github-team-consul-core @dnephin @trujillo-adam