-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for tls_cipher_suites #11070
Conversation
🤔 This PR has changes in the |
64bc3fc
to
aa1a478
Compare
I feel like this should wait until we change the build to use Go |
It's technically a breaking change so I wanted to put out a warning before we make the transition, but the actual impact might be negligible! I'm find with holding off on the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, but if we do indeed change to Go 1.17 in the next release I guess we'll want to change these notes from saying "in the future" to "In Consul 1.11".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/481951. |
🍒✅ Cherry pick of commit c0991f4 onto |
🍒✅ Cherry pick of commit c0991f4 onto |
Go 1.17 will change the behaviour of some TLS configs [link].
This commit updates the docs to clarify existing behaviour and warn of potential future changes.