Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test against go1.17 #11364

Merged
merged 1 commit into from
Oct 21, 2021
Merged

ci: test against go1.17 #11364

merged 1 commit into from
Oct 21, 2021

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Oct 20, 2021 •
edited
Loading

Release notes: https://golang.org/doc/go1.17

TODO:

@dnephin dnephin added the pr/no-changelog PR does not need a corresponding .changelog entry label Oct 20, 2021
@github-actions github-actions bot added the type/ci Relating to continuous integration (CI) tooling for testing or releases label Oct 20, 2021
@dnephin dnephin marked this pull request as ready for review October 21, 2021 15:49
@dnephin dnephin requested a review from a team October 21, 2021 15:49
@dnephin dnephin removed the pr/no-changelog PR does not need a corresponding .changelog entry label Oct 21, 2021
@vercel vercel bot temporarily deployed to Preview – consul October 21, 2021 19:02 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 19:02 Inactive
@rboyer
Copy link
Member

rboyer commented Oct 21, 2021

Both build-support/docker/Build-Go.dockerfile and build-support/docker/Test-Flake.dockerfile need updating as well.

@vercel vercel bot temporarily deployed to Preview – consul October 21, 2021 20:18 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging October 21, 2021 20:18 Inactive
@dnephin
Copy link
Contributor Author

dnephin commented Oct 21, 2021

Thanks! I didn't know we had pinned Go versions in other places. I've made those changes. I think I will also prepare a PR to remove the test flake stuff and replace it with some docs.

@dnephin dnephin merged commit 846ff9a into main Oct 21, 2021
@dnephin dnephin deleted the use-go1.17 branch October 21, 2021 20:52
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/482130.

@dhiaayachi dhiaayachi mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

Assignees
No one assigned
Labels
type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnephin @rboyer @hc-github-team-consul-core @kisunji