Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: Clean up unused built-in proxy config #11165

Merged
merged 1 commit into from
Sep 28, 2021
Merged

agent: Clean up unused built-in proxy config #11165

merged 1 commit into from
Sep 28, 2021

Conversation

kisunji
Copy link
Contributor

@kisunji kisunji commented Sep 28, 2021 •
edited
Loading

Resolves #9580
References to these members were previously removed in #6220.

@kisunji kisunji requested a review from a team as a code owner September 28, 2021 15:03
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 28, 2021
@kisunji kisunji added the pr/no-changelog PR does not need a corresponding .changelog entry label Sep 28, 2021
blake
blake approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@blake blake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashicorp-ci
Copy link
Contributor

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@kisunji kisunji merged commit e3248c2 into main Sep 28, 2021
@kisunji kisunji deleted the kisunji/cleanupmanagedproxy branch September 28, 2021 15:29
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/458624.

@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit e3248c2 onto stable-website succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Sep 28, 2021
@hc-github-team-consul-core
agent: Clean up unused built-in proxy config (#11165)
7afc8b8
@hc-github-team-consul-core
Copy link
Contributor

🍒✅ Cherry pick of commit e3248c2 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Sep 28, 2021
@hc-github-team-consul-core
agent: Clean up unused built-in proxy config (#11165)
9b68c5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blake blake blake approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable_tcp_check and tcp_check_address do not impact sidecar configuration
4 participants
@kisunji @hashicorp-ci @hc-github-team-consul-core @blake