Remove Connect Managed Proxies #6220
Conversation
mikemorris
force-pushed
the
rm-managed-proxies
branch
from
e737e10
to
3a4b476
Compare
mikemorris
force-pushed
the
rm-managed-proxies
branch
from
59ca5d9
to
40702b3
Compare
There was a problem hiding this comment.
That was a mammoth sized PR. Overall everything looks in order. I added a few notes thoughout (I will resolve some of them shortly as it will be easier to find them once I complete the review).
CI will catch Envoy integration issues but have you gone through the Connect guide on Learn using the builtin proxy. Thats probably the quickest way to ensure things work as expected.
| @@ -248,7 +229,7 @@ func (s *HTTPServer) AgentServices(resp http.ResponseWriter, req *http.Request) | |||
|
|
|||
| // Use empty list instead of nil | |||
| for id, s := range services { | |||
| agentService := buildAgentService(s, proxies) | |||
| agentService := buildAgentService(s) | |||
There was a problem hiding this comment.
Adding this here as a note that we should probably double check the v1/agent/services output on 1.6.0 beta 3 against this branch when non-managed sidecar proxies are used. I believe all should be well but it would be good to verify that central config still gets factored into the output here.
|
Given some of my uncertainty around the Are there any unit tests I should be adding here? It seems like some of the CLI flag/env var functionality is untested currently - any suggestions of examples or patterns would be appreciated. |
agent-global config structs and associated tests
mikemorris
force-pushed
the
rm-managed-proxies
branch
from
e09a737
to
7ece6fb
Compare
|
There's some future work that may be nice here to consolidate the interface, environment variables and CLI flags common to built-in proxies and Envoy (and any future proxy integrations), but punting on that for now in favor of minimizing optional refactoring in what is a pretty massive PR already. I walked through the Connect tutorial again and the built-in proxy functionality appears to be working just fine, think this should be ready to squash! |
mikemorris
dismissed
rboyer’s stale review
Requested changes have been addressed.
| "ModifyIndex": 0 | ||
| } | ||
| ], | ||
| "passing": [ |
There was a problem hiding this comment.
I think you nuked 312->340 by accident.
Closes #5848
This is feeling big and I definitely need a gut check on if I'm inadvertently removing unrelated things that just happen to reference other proxies.
consul connect envoystill use the environment variables defined in theproxyprocessinterface?proxyprocess?ProxyManagersupervisionConnect.ProxyandConnect.ProxyDefaultsobjects be completely gone now? YES, remove from service definition and global config.service.connect.proxykey in service definitions go away? YES./v1/agent/connect/proxy/:proxy_idendpoint go away? YES.Agentstill need to be able toverifyProxyTokenandresolveProxyToken?TestAgentConnectCALeafCert_aclDefaultDeny) that appear to incidentally configure a managed proxy - how should these tests be refactored?