-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acl: rename ResolveTokenToIdentityAndAuthorizer to ResolveToken #12167
Conversation
7d48325
to
3785314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to comb through the tests a bit closer, but the code changes look good. Should help cut down on confusion around when to use which method. 👍🏽
3785314
to
8ace474
Compare
8ace474
to
e4d0b9f
Compare
e2dd510
to
d363cc0
Compare
This change allows us to remove one of the last remaining duplicate resolve token methods (Server.ResolveToken). With this change we are down to only 2, where the second one also handles setting the default EnterpriseMeta from the token.
e4d0b9f
to
343b6de
Compare
Test failure is a known flake in |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/571813. |
Branched from #12166, continues the work described in #11690
This change allows us to remove one of the last remaining duplicate resolve token methods (
Server.ResolveToken
).With this change we are down to only 2, where the second one also handles setting the default EnterpriseMeta from the token.