acl: demonstrate new authz interface #12169
Conversation
dnephin
added
the
pr/no-changelog
dnephin
added
theme/acls
dnephin
force-pushed
the
dnephin/acl-resolve-token-3
branch
from
3785314
to
8ace474
Compare
dnephin
force-pushed
the
dnephin/acl-resolve-token-5
branch
from
e5eda83
to
0eaa784
Compare
| @@ -1132,6 +1133,27 @@ func (a ACLResolveResult) AccessorID() string { | |||
| return a.ACLIdentity.ID() | |||
| } | |||
|
|
|||
| type ACLKVResourceID interface { | |||
| KVResourceID() string | |||
There was a problem hiding this comment.
I'm not sure if we want a separate interface for each resource type, or a small number of interfaces (one for resources with identifiers+entMeta, one for just identifiers, and one for just entMeta).
dnephin
force-pushed
the
dnephin/acl-resolve-token-3
branch
2 times, most recently
from
e4d0b9f
to
343b6de
Compare
dnephin
force-pushed
the
dnephin/acl-resolve-token-5
branch
from
0eaa784
to
18767b4
Compare
|
|
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
Branched from #12167, demonstrates the authorization interface proposed in #11690.
This PR also demonstrates how we can used a typed error, built in a centralized place, to provide better error messages when permission is denied.
TODO:
Causefield fromPermissionDeniedErrorACLResolveResultand the types used in its method signatures to a new package underacl/maybeacl/aclauthzor something like that.