Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go version to 1.18.1 #12808

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Update go version to 1.18.1 #12808

merged 1 commit into from
Apr 18, 2022

Conversation

DanStough
Copy link
Contributor

Updates to facilitate Go 1.18. Highlights on Changes:

  • MOG updates which were released to deal with 1.18 changes
  • Linter Update to Support 1.18 changes
  • Misc Linter Fixes
  • CI Runner updates
  • Regenerated Test Certificates w/o using SHA1
  • Deprecation Fixes

Deprecations:

  • Verifying Certs w/ SHA1 signatures
  • x509.CertPool.Subjects()
  • Strings.Title()

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 15, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/contributing Additions and enhancements to community contributing materials theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication type/ci Relating to continuous integration (CI) tooling for testing or releases labels Apr 15, 2022
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 21:04 Inactive
@DanStough DanStough requested a review from a team April 15, 2022 21:04
DanStough
DanStough commented Apr 15, 2022
View reviewed changes
connect/tls.go Outdated Show resolved Hide resolved
@DanStough DanStough marked this pull request as ready for review April 15, 2022 21:13
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
api/api_test.go Outdated Show resolved Hide resolved
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
api/api_test.go Outdated Show resolved Hide resolved
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
agent/agent_test.go Outdated Show resolved Hide resolved
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
agent/agent_test.go Outdated Show resolved Hide resolved
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
agent/agent_test.go Outdated Show resolved Hide resolved
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
tlsutil/config.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 21:52 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 21:52 Inactive
rboyer
rboyer reviewed Apr 15, 2022
View reviewed changes
tlsutil/config.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul April 15, 2022 22:41 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 15, 2022 22:41 Inactive
acpana
acpana reviewed Apr 15, 2022
View reviewed changes
Copy link
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome 💯 ! Thanks for working on this 🥇 ; and congrats on your first PR 🎉 !!

I left some questions and nits; It looks like you're working with RB so I'll defer to him for final approval.

Things LGTM overall!!

.changelog/12808.txt Outdated Show resolved Hide resolved
agent/consul/leader_connect_ca.go Outdated Show resolved Hide resolved
api/api_test.go Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
agent/connect_ca_endpoint_test.go Show resolved Hide resolved
sdk/testutil/testlog.go Outdated Show resolved Hide resolved
tlsutil/config.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 18, 2022 13:34 Inactive
@vercel vercel bot temporarily deployed to Preview – consul April 18, 2022 13:34 Inactive
rboyer
rboyer reviewed Apr 18, 2022
View reviewed changes
connect/service_test.go
@@ -288,3 +290,15 @@ func TestService_HasDefaultHTTPResolverFromAddr(t *testing.T) {
require.NoError(t, err)
require.Equal(t, expected, got)
}

func getSubjects(cp *x509.CertPool) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe drop a TODO here for the future to reevaluate the kind of comparison we should do here.

@DanStough DanStough merged commit 95250e7 into main Apr 18, 2022
@DanStough DanStough deleted the ds.go-1.18.1 branch April 18, 2022 15:41
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/642045.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 95250e7 onto release/1.12.x succeeded!

@eculver eculver mentioned this pull request Apr 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpana acpana acpana left review comments

@rboyer rboyer rboyer approved these changes

Assignees
No one assigned
Labels
pr/dependencies PR specifically updates dependencies of project theme/api Relating to the HTTP API interface theme/certificates Related to creating, distributing, and rotating certificates in Consul theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies theme/contributing Additions and enhancements to community contributing materials theme/tls Using TLS (Transport Layer Security) or mTLS (mutual TLS) to secure communication type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanStough @hashicorp-cla @hc-github-team-consul-core @rboyer @acpana