Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run arm64 builds on go1.18 #12818

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Run arm64 builds on go1.18 #12818

merged 1 commit into from
Apr 19, 2022

Conversation

eculver
Copy link
Contributor

@eculver eculver commented Apr 18, 2022

We recently updated the version of Go we build with to 1.18 in #12808. I think we may have missed this one place in the builds for arm64.

I won't be attaching a changelog as this is part of #12808.

@eculver eculver added the pr/no-changelog PR does not need a corresponding .changelog entry label Apr 18, 2022
@eculver eculver requested a review from DanStough April 18, 2022 23:56
@github-actions github-actions bot added the type/ci Relating to continuous integration (CI) tooling for testing or releases label Apr 18, 2022
@@ -257,8 +257,8 @@ jobs:
- run:
command: |
sudo rm -rf /usr/local/go
wget https://golang.org/dl/go1.17.5.linux-arm64.tar.gz
sudo tar -C /usr/local -xzvf go1.17.5.linux-arm64.tar.gz
wget https://dl.google.com/go/go1.18.1.linux-arm64.tar.gz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the domain here to https://dl.google.com because golang.org/dl eventually redirects here.

@eculver eculver requested a review from a team April 19, 2022 00:10
@eculver eculver merged commit fb7022b into main Apr 19, 2022
@eculver eculver deleted the eculver/arm-tests-1.18 branch April 19, 2022 06:13
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/643218.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants