fix for , non presence of consul-version meta (#18464) #18561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for #18406 , non presence of consul-version meta * removed redundant checks * updated mock-api to mimic api response for synthetic nodes * added test to test getDistinctConsulVersions method with synthetic-node case * updated typo in comments * added change log
WenInCode
approved these changes
Aug 23, 2023
absolutelightning
pushed a commit
that referenced
this pull request
Sep 4, 2023
…to release/1.16.x (#18520) resolve conflict Co-authored-by: temp <temp@hashicorp.com> Backport of bug: prevent go routine leakage due to existing DeferCheck into release/1.16.x (#18565) * backport of commit 06d4c72 * backport of commit 42c37bb --------- Co-authored-by: cskh <hui.kang@hashicorp.com> fix for , non presence of consul-version meta (#18464) (#18561) * fix for #18406 , non presence of consul-version meta Co-authored-by: Vijay <vijayraghav22@gmail.com> [BACKPORT] 1.16.x manual backport of OSS->CE branch (#18549) Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.16.x (#18570) backport of commit c833fcc Co-authored-by: NiniOak <anita.akaeze@hashicorp.com> Backport of docs: Fix spelling errors across various pages on the site into release/1.16.x (#18537) docs: Fix spelling errors across various pages on the site (#18533) This commit fixes numerous spelling errors across the site and also removes unnecessary whitespace that was present in the edited files. Co-authored-by: Blake Covarrubias <blake@covarrubi.as> Backport of Fix broken link on sameness group page into release/1.16.x (#18588) backport of commit 05dd1a8 Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manual backport of #18464
Testing & Reproduction steps
Links
PR Checklist