Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of bug: prevent go routine leakage due to existing DeferCheck into release/1.16.x #18565

Conversation

hc-github-team-consul-core
Copy link
Contributor

Backport

This PR is auto-generated from #18558 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

Prevent go routine leakage due to existing DeferCheck

Please refer to #18429 how to reproduce.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/gh-18429-deferrcheck-leak/yearly-rested-amoeba branch from c0cb957 to 62b08ce Compare August 23, 2023 14:33
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/gh-18429-deferrcheck-leak/yearly-rested-amoeba branch from 62b08ce to 9dffdcb Compare August 23, 2023 14:33
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/gh-18429-deferrcheck-leak/yearly-rested-amoeba branch from 1390abe to 4d272f3 Compare August 23, 2023 14:33
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 23, 2023 14:36 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 23, 2023 14:38 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 0d0c5d0 into release/1.16.x Aug 23, 2023
80 checks passed
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/gh-18429-deferrcheck-leak/yearly-rested-amoeba branch August 23, 2023 15:04
absolutelightning pushed a commit that referenced this pull request Sep 4, 2023
…to release/1.16.x (#18520)

resolve conflict

Co-authored-by: temp <temp@hashicorp.com>

Backport of bug: prevent go routine leakage due to existing DeferCheck into release/1.16.x (#18565)

* backport of commit 06d4c72

* backport of commit 42c37bb

---------

Co-authored-by: cskh <hui.kang@hashicorp.com>

fix for , non presence of consul-version meta (#18464) (#18561)

* fix for #18406 , non presence of consul-version meta

Co-authored-by: Vijay <vijayraghav22@gmail.com>

[BACKPORT] 1.16.x manual backport of OSS->CE branch (#18549)

Backport of NET-5382 & PLAT-1159: Do not trigger workflow if only doc files are in commit history into release/1.16.x (#18570)

backport of commit c833fcc

Co-authored-by: NiniOak <anita.akaeze@hashicorp.com>

Backport of docs: Fix spelling errors across various pages on the site into release/1.16.x (#18537)

docs: Fix spelling errors across various pages on the site (#18533)

This commit fixes numerous spelling errors across the site and also
removes unnecessary whitespace that was present in the edited files.

Co-authored-by: Blake Covarrubias <blake@covarrubi.as>

Backport of Fix broken link on sameness group page into release/1.16.x (#18588)

backport of commit 05dd1a8

Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants