Backport of Cc 5545: Upgrade HDS packages and modifiers into release/1.17.x #19245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version file to 1.18-dev, and replace 1.13 nightly test with 1.17.
This change adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default operator:x permissions. It refactors a lot of the common testing functions so that they can be re-used between resources. There are also some types that we don't yet support (e.g. virtual IPs) that this change adds ACL hooks to for future-proofing.
…19187) * NET-5073 - ProxyConfiguration: implement various connection options * PR feedback - LocalConnection and InboundConnection do not affect exposed routes. configure L7 route destinations. fix connection proto sequence numbers. * add timeout to L7 Route Destinations
Co-authored-by: Ronald Ekambi <ronekambi@gmail.com>
Enhance the xRoute ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.
Enhance the DestinationPolicy ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.
hc-github-team-consul-core
force-pushed
the
backport/CC-5545/no-big-changes-for-tylers-pr/violently-suitable-caiman
branch
from
f19daa7 to
7be8f75
Compare
hc-github-team-consul-core
force-pushed
the
backport/CC-5545/no-big-changes-for-tylers-pr/violently-suitable-caiman
branch
from
3ae1ad9 to
9d9714e
Compare
github-team-consul-core-pr-approver
approved these changes
Oct 17, 2023
github-actions
bot
added
type/docs
hc-github-team-consul-core
deleted the
backport/CC-5545/no-big-changes-for-tylers-pr/violently-suitable-caiman
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19226 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
#19210
Trying to redo this PR but without all of the whitespace changes
Description from other PR
Description
Upgrades HDS packages to latest releases ahead of work for adding the HDS Side Nav to the UI.
Upgrading
@hashicorp/design-system-componentscausedember-modifierto resolve to a4.xversion which was not compatible with a bunch of our class modifiers as well as one our packages that was outdated (ember-in-viewport). Due to this I explicitly updated consul-ui to use the latestember-modifierandember-in-viewportpackages.Because of the above I had to go through and update all the class based modifiers to use the new modifier structure.
Upgraded
ember-on-resize-modifierto fix issue where routing edge rects weren't getting set.A nice video where I find out routing of all things has an issue at the end:
(this ends with me finding an issue with routing edges which I fixed after, see next screenshot)
video1069237399.mp4
Testing & Reproduction steps
Links
CC-5545
PR Checklist
Overview of commits