-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of CC-5545: Side Nav into release/1.17.x #19524
Closed
hc-github-team-consul-core
wants to merge
131
commits into
release/1.17.x
from
backport/CC-5545/side-nav/intensely-accepted-beagle
Closed
Backport of CC-5545: Side Nav into release/1.17.x #19524
hc-github-team-consul-core
wants to merge
131
commits into
release/1.17.x
from
backport/CC-5545/side-nav/intensely-accepted-beagle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update version file to 1.18-dev, and replace 1.13 nightly test with 1.17.
This change adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default operator:x permissions. It refactors a lot of the common testing functions so that they can be re-used between resources. There are also some types that we don't yet support (e.g. virtual IPs) that this change adds ACL hooks to for future-proofing.
…19187) * NET-5073 - ProxyConfiguration: implement various connection options * PR feedback - LocalConnection and InboundConnection do not affect exposed routes. configure L7 route destinations. fix connection proto sequence numbers. * add timeout to L7 Route Destinations
Co-authored-by: Ronald Ekambi <ronekambi@gmail.com>
Enhance the xRoute ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.
Enhance the DestinationPolicy ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.
* typo fixes and instruction corrections * typo * link path correction
* Update dns-configuration.mdx * Update website/content/docs/services/discovery/dns-configuration.mdx Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
….0 (#19225) * Bump golang.org/x/net to 0.17.0 This resolves [CVE-2023-39325](https://nvd.nist.gov/vuln/detail/CVE-2023-39325) / [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487). * Update Go version to 1.20.10 This resolves [CVE-2023-39325](https://nvd.nist.gov/vuln/detail/CVE-2023-39325) / [CVE-2023-44487](https://nvd.nist.gov/vuln/detail/CVE-2023-44487) (`net/http`).
* Upgrade @hashicorp/design-system-tokens to 1.9.0 * Upgrade @hashicorp/design-system-components to 1.8.1 * Upgrade @hashicorp/design-system-components and ember-in-viewport * Explicitly install ember-modifier@4.1.0 * rename copy-button * Fix how cleanup is done in with-copyable * Update aria-menu modifier for new structure * Update css-prop modifier to new structure * Convert did-upsert to regular class modifier * Update notification modifier for new structure * Update on-oustside modifier for new structure * Move destroy handler registration in with-copyable * Update style modifier for new structure * Update validate modifier for new structure * Guard against setting on destroyed object * Upgrade @hashicorp/design-system-components to 2.14.1 * Remove debugger * Guard against null in aria-menu * Fix undefined hash in validate addon * Upgrade ember-on-resize-modifier * Fix copy button import, missing import and array destructuring --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>
CE changes for multiple virtual hosts
…#19119) * NET-5592 - update Nomad integration testing * NET-4893: Ensure we're testing all the latest versions of Vault/Nomad
The control-plane-request-limit config entry does not support specifying parameter names in snake case format. This commit updates the HCL and JSON examples to use the supported camel case key format.
When testing adding http probes to apps, I ran into some issues which I fixed here: - The listener should be listening on the exposed listener port, updated that. - The listener and route names were pointing to the path of the exposed path. In my test, the path was "/" resulting in an empty string path. Also, the path may not be unique across exposed path listeners, so I decided to use the path+exposed port as the unique identifier.
* Add sentence * link text adjustment
* Update configure.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
…maid diagram with their dependencies (#19230)
Ensure LB policy set for locality-aware routing (CE) `overprovisioningFactor` should be overridden with the expected value (100,000) when there are multiple endpoint groups. Update code and tests to enforce this. This is an Enterprise feature. This commit represents the CE portions of the change; tests are added in the corresponding `consul-enterprise` change.
* fix: allow snake case keys for ip based rate limit config entry * chore: add changelog
hc-github-team-consul-core
force-pushed
the
backport/CC-5545/side-nav/intensely-accepted-beagle
branch
from
November 6, 2023 15:20
7641940
to
76be80b
Compare
hc-github-team-consul-core
requested review from
sarahethompson
and removed request for
a team
November 6, 2023 15:20
hc-github-team-consul-core
force-pushed
the
backport/CC-5545/side-nav/intensely-accepted-beagle
branch
from
November 6, 2023 15:20
0f5124c
to
3a4f8aa
Compare
github-team-consul-core-pr-approver
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto approved Consul Bot automated PR
github-actions
bot
added
type/docs
Documentation needs to be created/updated/clarified
theme/api
Relating to the HTTP API interface
theme/acls
ACL and token generation
theme/cli
Flags and documentation for the CLI interface
theme/config
Relating to Consul Agent configuration, including reloading
theme/ui
Anything related to the UI
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
type/ci
Relating to continuous integration (CI) tooling for testing or releases
pr/dependencies
PR specifically updates dependencies of project
theme/envoy/xds
Related to Envoy support
theme/contributing
Additions and enhancements to community contributing materials
labels
Nov 6, 2023
4 tasks
Closing in favour of #19573 |
auto-merge was automatically disabled
November 7, 2023 23:34
Pull request was closed
WenInCode
deleted the
backport/CC-5545/side-nav/intensely-accepted-beagle
branch
November 7, 2023 23:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr/dependencies
PR specifically updates dependencies of project
theme/acls
ACL and token generation
theme/api
Relating to the HTTP API interface
theme/cli
Flags and documentation for the CLI interface
theme/config
Relating to Consul Agent configuration, including reloading
theme/connect
Anything related to Consul Connect, Service Mesh, Side Car Proxies
theme/contributing
Additions and enhancements to community contributing materials
theme/envoy/xds
Related to Envoy support
theme/ui
Anything related to the UI
type/ci
Relating to continuous integration (CI) tooling for testing or releases
type/docs
Documentation needs to be created/updated/clarified
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19342 to be assessed for backporting due to the inclusion of the label backport/1.17.
The below text is copied from the body of the original PR.
Description
Updates Consul UI to use HDS::SideNav. Adds client-side search for datacenter/partition/namespace selectors.
Adds translations for side nav elements (not including login modal).
Uprgades HDS to latest release
Testing & Reproduction steps
Links
https://hashicorp.atlassian.net/browse/CC-5545
PR Checklist
Overview of commits