Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CC-5545: side nav #19573

Merged

Conversation

WenInCode
Copy link
Contributor

@WenInCode WenInCode commented Nov 7, 2023

Description

Manual backport of #19342 ( replacing automatic backport #19524 )

Updates Consul UI to use HDS::SideNav. Adds client-side search for datacenter/partition/namespace selectors.

Also backports #19549 which was a follow up fix.

Adds translations for side nav elements (not including login modal).
Uprgades HDS to latest release

Screenshot 2023-10-23 at 4 11 39 PM Screenshot 2023-10-23 at 4 11 27 PM Screenshot 2023-10-23 at 4 11 24 PM Screenshot 2023-10-23 at 4 11 15 PM Screenshot 2023-10-23 at 4 09 50 PM Screenshot 2023-10-23 at 4 09 43 PM Screenshot 2023-10-23 at 4 09 23 PM Screenshot 2023-10-23 at 4 09 19 PM Screenshot 2023-10-23 at 4 47 08 PM

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@WenInCode WenInCode added theme/ui Anything related to the UI pr/no-backport labels Nov 7, 2023
@WenInCode WenInCode enabled auto-merge (squash) November 8, 2023 00:05
Copy link
Contributor

@valeriia-ruban valeriia-ruban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@WenInCode WenInCode merged commit 43ae89e into release/1.17.x Nov 8, 2023
96 checks passed
@WenInCode WenInCode deleted the backport/CC-5545/side-nav/banana-stand-money branch November 8, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-backport theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants