Backport of [NET-8601] security: upgrade vault/api to remove go-jose.v2 into release/1.17.x #21052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20910 to be assessed for backporting due to the inclusion of the label backport/1.17.
🚨
The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
This dependency has an open vulnerability (GO-2024-2631 AKA CVE-2024-28180), and is no longer needed by the latest
vault/api
. This is a follow-up to the upgrade ofgo-jose/v3
in this repository to make all our dependencies consolidate on v3.Also remove the recently added security scan triage block for GO-2024-2631, which was added due to incorrect reports that
go-jose/v3@3.0.3
was impacted; in reality, is was this indirect client dependency (not impacted by CVE) that the scanner was flagging. A bug report has been filed to address the incorrect reporting.This PR will fail some backports due to
go.mod
/go.sum
conflicts, but opening w/ labels to ensure we don't forget. I'll fix up the backports that fail.Description
vault/api
to latesttriage
block forgo-jose
from scanner configTesting & Reproduction steps
CI including Security Scan continue to pass.
Links
Follow-up to #20901
PR Checklist
Overview of commits