-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: triage false positive for go-jose/v3 #20901
Merged
zalimeni
merged 1 commit into
main
from
zalimeni/add-security-triage-go-jose-cve-false-positive
Mar 26, 2024
Merged
security: triage false positive for go-jose/v3 #20901
zalimeni
merged 1 commit into
main
from
zalimeni/add-security-triage-go-jose-cve-false-positive
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://osv.dev/vulnerability/GO-2024-2631 this vulnerability is not present in the version currently used (go-jose/v3@3.0.3).
zalimeni
added
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
backport/1.17
This release series is no longer active on CE. Use backport/ent/1.17.
backport/1.18
labels
Mar 26, 2024
zalimeni
requested review from
sarahethompson and
ashconnor
and removed request for
a team
March 26, 2024 21:04
dduzgun-security
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
zalimeni
added
the
pr/no-changelog
PR does not need a corresponding .changelog entry
label
Mar 26, 2024
Scan passed 🙌🏻 auto-merging. Thanks for the quick review @dduzgun-security ! |
zalimeni
deleted the
zalimeni/add-security-triage-go-jose-cve-false-positive
branch
March 26, 2024 21:27
This was referenced Mar 26, 2024
This was referenced Mar 26, 2024
This was referenced May 4, 2024
Closed
Closed
Closed
4 tasks
This was referenced Sep 26, 2024
Backport of security: triage false positive for go-jose/v3 into release/1.18.1
dhiaayachi/consul#709
Open
Backport of security: triage false positive for go-jose/v3 into release/1.18.x
dhiaayachi/consul#710
Open
Backport of security: triage false positive for go-jose/v3 into release/1.17.x
dhiaayachi/consul#712
Open
Backport of security: triage false positive for go-jose/v3 into release/1.16.x
dhiaayachi/consul#713
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
backport/1.17
This release series is no longer active on CE. Use backport/ent/1.17.
pr/no-changelog
PR does not need a corresponding .changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://osv.dev/vulnerability/GO-2024-2631 this vulnerability is not present in the version currently used (go-jose/v3@3.0.3).
I'm suspicious that the
Introduced 0
version in the OSV entry is why we're flagging the fix version as invalid. Just a guess.Description
This unblocks the Consul patch release currently underway.
Testing & Reproduction steps
CI continues to pass including Security Scan check.
PR Checklist