Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: triage false positive for go-jose/v3 #20901

Merged

Conversation

zalimeni
Copy link
Member

Per https://osv.dev/vulnerability/GO-2024-2631 this vulnerability is not present in the version currently used (go-jose/v3@3.0.3).

I'm suspicious that the Introduced 0 version in the OSV entry is why we're flagging the fix version as invalid. Just a guess.

Description

This unblocks the Consul patch release currently underway.

Testing & Reproduction steps

CI continues to pass including Security Scan check.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Per https://osv.dev/vulnerability/GO-2024-2631 this vulnerability is not
present in the version currently used (go-jose/v3@3.0.3).
@zalimeni zalimeni added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. backport/1.18 labels Mar 26, 2024
@zalimeni zalimeni requested review from david-yu, dduzgun-security, xwa153 and a team March 26, 2024 21:04
@zalimeni zalimeni requested a review from a team as a code owner March 26, 2024 21:04
@zalimeni zalimeni requested review from sarahethompson and ashconnor and removed request for a team March 26, 2024 21:04
Copy link
Collaborator

@dduzgun-security dduzgun-security left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zalimeni zalimeni added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 26, 2024
@zalimeni
Copy link
Member Author

zalimeni commented Mar 26, 2024

Scan passed 🙌🏻 auto-merging. Thanks for the quick review @dduzgun-security !

@zalimeni zalimeni enabled auto-merge (squash) March 26, 2024 21:08
@zalimeni zalimeni merged commit cc959dc into main Mar 26, 2024
112 of 117 checks passed
@zalimeni zalimeni deleted the zalimeni/add-security-triage-go-jose-cve-false-positive branch March 26, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants