agent: add default weights to service in local state to prevent AE churn #5126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Jan 7, 2019
| @@ -1880,6 +1880,12 @@ func (a *Agent) AddService(service *structs.NodeService, chkTypes []*structs.Che | |||
| } | |||
| } | |||
|
|
|||
| // Set default weights if not specified. This is important as it ensures AE | |||
| // doesn't consider the service different since it has nil weights. | |||
There was a problem hiding this comment.
Is this because on the server side they end up getting defaulted? This seems fine to me regardless, just trying to understand why there is a problem.
There was a problem hiding this comment.
Yep I think so as I understand it.
|
@banks the travis test failures look to be real and due to comparing nil to the new default weights. |
|
I think I fixed all the tests that broke due to this - will check CI again in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default weights when adding a service with no weights to local state to prevent constant AE re-sync.
This fix was contributed by @42wim in #5096 but was merged against the wrong base.
This adds it to master and adds a test to cover the behaviour.