Commits on Apr 3, 2020

1. BUGFIX hashicorp#7374 When a service does not exists in an alias, con… …

   …sider it failing
   
   In current implementation of Consul, check alias cannot determine
   if a service exists or not. Because a service without any check
   is semantically considered as passing, so when no healthchecks
   are found for an agent, the check was considered as passing.
   
   But this make little sense as the current implementation does not
   make any difference between:
    * a non-existing service (passing)
    * a service without any check (passing as well)
   
   In order to make it work, we have to ensure that when a check did
   not find any healthcheck, the service does indeed exists. If it
   does not, lets consider the check as failing.

   

   pierresouchay committed Apr 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for aab37a8
   • Browse repository at this point

   Copy the full SHA

   aab37a8 View commit details

   Browse the repository at this point in the history

2. Be sure to test new method agent.State.ServiceExists(serviceID)

   

   pierresouchay committed Apr 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for c85c3d8
   • Browse repository at this point

   Copy the full SHA

   c85c3d8 View commit details

   Browse the repository at this point in the history

3. Test fully end-to-end with agent RPC calls for alias checks

   

   pierresouchay committed Apr 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 2e785c1
   • Browse repository at this point

   Copy the full SHA

   2e785c1 View commit details

   Browse the repository at this point in the history

4. Remove agentName to NewTestAgent().

   

   pierresouchay committed Apr 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 87d5f73
   • Browse repository at this point

   Copy the full SHA

   87d5f73 View commit details

   Browse the repository at this point in the history