testing: Remove old default value from NewTestAgent() calls #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using:
git grep -l 'NewTestAgent(t, t.Name(),' | \
xargs sed -i -e 's/NewTestAgent(t, t.Name(),/NewTestAgent(t,/g'
dnephin
changed the title
dnephin
added
the
theme/internal-cleanup
After removing the t.Name() parameter with sed, convert the last few tests which use a custom name to call NewTestAgentWithFields instead.
This function now only starts the agent.
Using:
git grep -l 'StartTestAgent(t, true,' | \
xargs sed -i -e 's/StartTestAgent(t, true,/StartTestAgent(t,/g'
dnephin
force-pushed
the
dnephin/remove-tname-from-name
branch
from
dd56f91
to
e759daa
Compare
hanshasselberg
approved these changes
Apr 1, 2020
pierresouchay
added a commit
to pierresouchay/consul
that referenced
this pull request
Apr 1, 2020
Due to merge hashicorp#7562, upstream does not compile anymore. Error is: ERRO Running error: gofmt: analysis skipped: errors in package: [/Users/p.souchay/go/src/github.com/hashicorp/consul/agent/config_endpoint_test.go:188:33: too many arguments]
dnephin
added a commit
that referenced
this pull request
Apr 1, 2020
…change_args_in_NewTestAgent [FIX BUILD] fix build due to merge of #7562
pierresouchay
added a commit
to pierresouchay/consul
that referenced
this pull request
Apr 1, 2020
…d merge upstream. Due to hashicorp#7562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7546
NewTestAgentwas being called witht.Name(), which was removed from name. This PR removes the name and uses the default value.I also noticed that
NewTestAgentWithFieldswas only starting the agent, not creating a new one, so I renamed that to better reflect the behaviour.Mostly an automated change with: