Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: Remove old default value from NewTestAgent() calls #7562

Merged
merged 3 commits into from
Apr 1, 2020
Merged

testing: Remove old default value from NewTestAgent() calls #7562

merged 3 commits into from
Apr 1, 2020

Commits on Mar 31, 2020

  1. Remove name from NewTestAgent 

    Using:

git grep -l 'NewTestAgent(t, t.Name(),' | \
    xargs sed -i -e 's/NewTestAgent(t, t.Name(),/NewTestAgent(t,/g'
    @dnephin
    dnephin committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    475659a View commit details
    Browse the repository at this point in the history

  2. Convert the remaining calls to NewTestAgentWithFields 

    After removing the t.Name() parameter with sed, convert the last few tests which
use a custom name to call NewTestAgentWithFields instead.
    @dnephin
    dnephin committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    f9f6b14 View commit details
    Browse the repository at this point in the history

  3. Rename NewTestAgentWithFields to StartTestAgent 

    This function now only starts the agent.

Using:

git grep -l 'StartTestAgent(t, true,' | \
        xargs sed -i -e 's/StartTestAgent(t, true,/StartTestAgent(t,/g'
    @dnephin
    dnephin committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    e759daa View commit details
    Browse the repository at this point in the history