Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Instance detail redesign #7683

Merged
merged 3 commits into from
Apr 22, 2020
Merged

ui: Instance detail redesign #7683

merged 3 commits into from
Apr 22, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 22, 2020 •
edited
Loading

These changes do not include the new proxy tab, but they do remove proxy tests that no longer have valid scenarios.

Preview of the Instance Detail page redesign

  • Remove Proxy link and add ExternalSource to instance detail page header
  • Create HealthChecks tab with route and styling
  • Fix up tests to fit redesign of Service Instances Detail page

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 22, 2020
@kaxcode kaxcode added this to the 1.8.0 milestone Apr 22, 2020
@kaxcode kaxcode requested review from hannahhearth, jnwright and a team April 22, 2020 00:00
johncowen
johncowen reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway we can split the breadcrumbs changes off into a separate PR? The changes to breadcrumbs will affect the entire UI throughout KV, Intentions, ACLs etc etc not just the instance detail page. If we do that we can just concentrate on the Instance detail redesign here, and the breadcrumbs changes in the separate PR.

P.S. Actually I've just looked at your commits, if this a hassle to don't worry we can go through it all as one PR, lemme know when you are about.

@kaxcode
Copy link
Contributor Author

kaxcode commented Apr 22, 2020

Is there anyway we can split the breadcrumbs changes off into a separate PR? The changes to breadcrumbs will affect the entire UI throughout KV, Intentions, ACLs etc etc not just the instance detail page. If we do that we can just concentrate on the Instance detail redesign here, and the breadcrumbs changes in the separate PR.

P.S. Actually I've just looked at your commits, if this a hassle to don't worry we can go through it all as one PR, lemme know when you are about.

@kaxcode kaxcode force-pushed the instance-detail-redesign branch 2 times, most recently from 4efab6d to edead71 Compare April 22, 2020 13:28
johncowen
johncowen approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I saw you asked about a design thing, but you have an approval for this when you are ready to go 🚀

@kaxcode kaxcode merged commit 872f2ec into ui-staging Apr 22, 2020
@kaxcode kaxcode deleted the instance-detail-redesign branch April 22, 2020 14:41
johncowen pushed a commit that referenced this pull request Apr 30, 2020
@kaxcode
ui: Instance detail redesign (#7683)
2458a21 
* Remove Proxy link and add ExternalSource to instance detail page header

* Create HealthChecks tab with route and styling

* Fix up tests to fit redesign of Service Instances Detail page
kaxcode added a commit that referenced this pull request May 11, 2020
@kaxcode
ui: Instance detail redesign (#7683)
2cc4d72 
* Remove Proxy link and add ExternalSource to instance detail page header

* Create HealthChecks tab with route and styling

* Fix up tests to fit redesign of Service Instances Detail page
johncowen pushed a commit that referenced this pull request May 12, 2020
@kaxcode
ui: Instance detail redesign (#7683)
8643565 
* Remove Proxy link and add ExternalSource to instance detail page header

* Create HealthChecks tab with route and styling

* Fix up tests to fit redesign of Service Instances Detail page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

@hannahhearth hannahhearth Awaiting requested review from hannahhearth

@jnwright jnwright Awaiting requested review from jnwright

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @johncowen @jnwright