-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Instance detail redesign #7683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anyway we can split the breadcrumbs changes off into a separate PR? The changes to breadcrumbs will affect the entire UI throughout KV, Intentions, ACLs etc etc not just the instance detail page. If we do that we can just concentrate on the Instance detail redesign here, and the breadcrumbs changes in the separate PR.
P.S. Actually I've just looked at your commits, if this a hassle to don't worry we can go through it all as one PR, lemme know when you are about.
7ad987f
to
b285f35
Compare
|
4efab6d
to
edead71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I saw you asked about a design thing, but you have an approval for this when you are ready to go 🚀
edead71
to
24aa7a5
Compare
* Remove Proxy link and add ExternalSource to instance detail page header * Create HealthChecks tab with route and styling * Fix up tests to fit redesign of Service Instances Detail page
* Remove Proxy link and add ExternalSource to instance detail page header * Create HealthChecks tab with route and styling * Fix up tests to fit redesign of Service Instances Detail page
* Remove Proxy link and add ExternalSource to instance detail page header * Create HealthChecks tab with route and styling * Fix up tests to fit redesign of Service Instances Detail page
These changes do not include the new proxy tab, but they do remove proxy tests that no longer have valid scenarios.
Preview of the Instance Detail page redesign