Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Redesign - Breadcrumbs styling #7687

Merged
merged 1 commit into from
Apr 23, 2020
Merged

ui: Redesign - Breadcrumbs styling #7687

merged 1 commit into from
Apr 23, 2020

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Apr 22, 2020

  • These styling changes affect many pages throughout the app.
  • No tests were broken by these changes.
  • Chevron-left icon updated to match design mockup.

Design:
Screen Shot 2020-04-22 at 8 35 38 AM

@kaxcode kaxcode added the theme/ui Anything related to the UI label Apr 22, 2020
@kaxcode kaxcode requested a review from a team April 22, 2020 12:37
@kaxcode kaxcode mentioned this pull request Apr 22, 2020
Merged
johncowen
johncowen reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you are going to revisit this a little re %crumbs but I left another couple of comments in here that I noticed immediately.

ui-v2/app/styles/base/icons/base-variables.scss Outdated Show resolved Hide resolved
ui-v2/app/styles/base/components/breadcrumbs/skin.scss Outdated Show resolved Hide resolved
@kaxcode kaxcode force-pushed the ui/feature/redesign-breadcrumbs branch from 615f114 to 9b27d59 Compare April 23, 2020 15:01
@kaxcode kaxcode requested a review from johncowen April 23, 2020 15:11
johncowen
johncowen approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaxcode kaxcode merged commit b6313e7 into ui-staging Apr 23, 2020
@kaxcode kaxcode deleted the ui/feature/redesign-breadcrumbs branch April 23, 2020 15:29
johncowen pushed a commit that referenced this pull request Apr 30, 2020
@kaxcode
ui: Update Breadcrumbs styling (#7687)
6672ffe
kaxcode added a commit that referenced this pull request May 11, 2020
@kaxcode
ui: Update Breadcrumbs styling (#7687)
2240a8c
johncowen pushed a commit that referenced this pull request May 12, 2020
@kaxcode
ui: Update Breadcrumbs styling (#7687)
893ee7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxcode @johncowen