Merge pull request #95 from hashicorp/move-important-information

Update "Button" documentation
hashicorp · Mar 18, 2022 · 541469c · 541469c · vercel · Mar 18, 2022
2 parents 8a29645 + 91f79a1
commit 541469c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/packages/components/tests/dummy/app/styles/components/dummy-component-props.scss b/packages/components/tests/dummy/app/styles/components/dummy-component-props.scss
@@ -29,6 +29,10 @@
  margin: 0;
  }
 
+ p + p {
+ margin-top: 0.125rem;
+ }
+
  ol {
  display: flex;
  flex-wrap: wrap;

diff --git a/packages/components/tests/dummy/app/templates/components/button.hbs b/packages/components/tests/dummy/app/templates/components/button.hbs
@@ -33,6 +33,10 @@
  <dt>icon <code>string</code></dt>
  <dd>
  <p>Use this parameter to show an icon. Acceptable value: any Flight icon name.</p>
+ <p><strong>🚨 IMPORTANT:</strong>
+ <code class="dummy-code">tertiary</code>
+ buttons are required to have either a leading or trailing icon to be accessible.</p>
+
  </dd>
  <dt>iconPosition <code>enum</code></dt>
  <dd>
@@ -112,9 +116,6 @@
  {{! prettier-ignore-end }}
  <p class="dummy-paragraph">Renders to:</p>
  <Hds::Button @text="Copy to clipboard" @icon="clipboard-copy" />
- <p class="dummy-paragraph"><strong>🚨 IMPORTANT:</strong>
- <code class="dummy-code">tertiary</code>
- buttons are required to have either a leading or trailing icon to be accessible.</p>
 
  <h4 class="dummy-h4">Icon position</h4>
  <p class="dummy-paragraph">By default, if you define an icon, it is placed before the text. If you would like to