Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Button" documentation #95

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Update "Button" documentation #95

merged 1 commit into from
Mar 18, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Mar 18, 2022

📌 Summary

The information that the tertiary button needs always an icon was buried in the examples and some people missed this critical information. Better to move it to the context of the icon prop.

🛠️ Detailed description

In this PR I have:

  • moved the information in a more prominent/contextual position.

📸 Screenshots

How it looks now:
screenshot_1125


👀 How to review

👉 Review by files changed

💬 Please consider using conventional comments when reviewing this PR.

@didoo didoo requested a review from a team March 18, 2022 17:39
@vercel
Copy link

vercel bot commented Mar 18, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/B2y5AhUeQfTmZeU2NRHiVk6iYWLq
✅ Preview: https://hds-flight-website-git-move-important-information-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/3EmaYHfj1VBRfCMgQZxM3HndQBxa
✅ Preview: https://hds-components-git-move-important-information-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

⚠️ No Changeset found

Latest commit: 91f79a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@didoo didoo merged commit 541469c into main Mar 18, 2022
@didoo didoo deleted the move-important-information branch March 18, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants