-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "Link/LinkTo::CTA" component (03) #221
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/Ee9sET7rta9JbNujsjq1oPP71HQt hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/8wuXM7mPWWjuNMbtXJ1FmF9pVoKT |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d41acff
to
abd2aac
Compare
35093db
to
81d5878
Compare
# Conflicts: # packages/components/tests/dummy/app/templates/components/link-to/cta.hbs # packages/components/tests/dummy/app/templates/components/link/cta.hbs
packages/components/addon/components/hds/dropdown/list-item/copy-item.js
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/components/tests/dummy/app/router.js # packages/components/tests/dummy/app/templates/components/link/cta.hbs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing seem to have changed since the last review, but I'll approve again, as requested.
📌 Summary
Now that we the
Hds::Button
can support also links (see #220) there's no more reason to have aHds::Link::CTA
component that is nothing more than a copy of theHds::Button
.For this reason, we can remove it from the HDS components library.
Notice: at the moment of writing the
Hds::Link::CTA
component has not been adopted yet in Cloud UI, so there are no needs for refactoring or changes on their side, we can safely remove the component without impacting the consumers.🛠️ Detailed description
In this PR I have:
Link/LinkTo::CTA
from the codebase👀 How to review
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.