Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Link/LinkTo::CTA" component (03) #221

Merged
merged 11 commits into from
May 19, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Apr 15, 2022

📌 Summary

Now that we the Hds::Button can support also links (see #220) there's no more reason to have a Hds::Link::CTA component that is nothing more than a copy of the Hds::Button.

For this reason, we can remove it from the HDS components library.

Notice: at the moment of writing the Hds::Link::CTA component has not been adopted yet in Cloud UI, so there are no needs for refactoring or changes on their side, we can safely remove the component without impacting the consumers.

🛠️ Detailed description

In this PR I have:

  • entirely removed Link/LinkTo::CTA from the codebase
    • component
    • documentation
    • tests (integration + percy)

👀 How to review

👉 Review by files changed

Reviewer's checklist:

  • +1 Percy if applicable

💬 Please consider using conventional comments when reviewing this PR.

@changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2022

⚠️ No Changeset found

Latest commit: 237e1cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Apr 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/Ee9sET7rta9JbNujsjq1oPP71HQt
✅ Preview: https://hds-flight-website-git-spike-remove-link-cta-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/8wuXM7mPWWjuNMbtXJ1FmF9pVoKT
✅ Preview: https://hds-components-git-spike-remove-link-cta-hashicorp.vercel.app

@didoo didoo changed the title [WIP] Remove the "Link/LinkTo::CTA" component [WIP] Remove the "Link/LinkTo::CTA" component (03) Apr 15, 2022
@didoo didoo changed the base branch from main to spike-button-with-link-support April 15, 2022 09:28
@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hds-components ✅ Ready (Inspect) Visit Preview May 19, 2022 at 10:51AM (UTC)
hds-flight-website ✅ Ready (Inspect) Visit Preview May 19, 2022 at 10:51AM (UTC)

@vercel vercel bot temporarily deployed to Preview – hds-components April 19, 2022 13:43 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 19, 2022 13:43 Inactive
@didoo didoo force-pushed the spike-button-with-link-support branch from d41acff to abd2aac Compare April 20, 2022 13:29
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 20, 2022 14:15 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 20, 2022 14:15 Inactive
@didoo didoo force-pushed the spike-remove-link-CTA branch from 35093db to 81d5878 Compare April 20, 2022 14:19
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 20, 2022 14:21 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 20, 2022 14:21 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 20, 2022 14:40 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 20, 2022 14:41 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website April 20, 2022 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components April 20, 2022 14:44 Inactive
@didoo didoo requested a review from a team April 21, 2022 07:55
@didoo didoo marked this pull request as ready for review April 21, 2022 07:56
@didoo didoo changed the title [WIP] Remove the "Link/LinkTo::CTA" component (03) Remove the "Link/LinkTo::CTA" component (03) Apr 21, 2022
# Conflicts:
#	packages/components/tests/dummy/app/templates/components/link-to/cta.hbs
#	packages/components/tests/dummy/app/templates/components/link/cta.hbs
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 5, 2022 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 5, 2022 20:21 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 11, 2022 09:54 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 11, 2022 09:54 Inactive
.github/workflows/release.yml Outdated Show resolved Hide resolved
# Conflicts:
#	packages/components/tests/dummy/app/router.js
#	packages/components/tests/dummy/app/templates/components/link/cta.hbs
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 11, 2022 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 11, 2022 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 11, 2022 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 11, 2022 13:28 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 11, 2022 13:31 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 11, 2022 13:31 Inactive
@didoo didoo requested review from MelSumner and Dhaulagiri May 18, 2022 16:09
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 18, 2022 16:10 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 18, 2022 16:11 Inactive
@didoo didoo requested a review from alex-ju May 18, 2022 16:57
@vercel vercel bot temporarily deployed to Preview – hds-components May 18, 2022 17:46 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 18, 2022 17:46 Inactive
Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seem to have changed since the last review, but I'll approve again, as requested.

@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 19, 2022 10:50 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 19, 2022 10:51 Inactive
@didoo didoo merged commit dff380e into spike-button-with-link-support May 19, 2022
@didoo didoo deleted the spike-remove-link-CTA branch May 19, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants