Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button/Link/CTA - Updates for the interactive elements #217

Merged
merged 126 commits into from
May 26, 2022

Conversation

didoo
Copy link
Contributor

@didoo didoo commented Apr 14, 2022

📌 Summary

This is the "feature branch" used to collect in one single place all the changes proposed to the Button/Link/CTA components. For more details about the reasons and rationale why these changes are proposed, please refer to the single PRs and to the RFC document linked below.

The following PRs need to be reviewed and merged in this order:

  1. "Interactive" generic component (01) #216 - ✅
  2. Extend the "Button" component to support also links as actions (02) #220 - ✅
  3. Remove the "Link/LinkTo::CTA" component (03) #221 - ✅
  4. Unify "Link/LinkTo::Standalone" component (04) #227 - ✅
  5. Add "Link::Inline" component (05) #231 - ✅

Once they're all merged (if approved) in this branch, we'll do a final review of the code to make sure we're not missing or forgetting something, and once this PR is approved it can be merged in main and the proposed changes officially released.

🚧 TODOs

Once all the branches are merged:

  • updated screenshots for documentation for designers (from Figma)
    • decided we'll add in a follow-up PR
  • update the Links, Buttons, CTAs...oh my! block (probably following a similar update in the documentation in Figma)
    • hiding for now, we will re-add it later once it's been updated also in Figma
  • decide what kind of release we want to do (minor = 0.12.0 or major = 1.0.0) - notice: this will be a major breaking change from the code perspective
    • @Dhaulagiri decided to go with minor release
    • add the changeset file accordingly

🔗 Links


👀 How to review

👉 Review by files changed

Updated documentation pages:

Reviewer's checklist:

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.


@vercel
Copy link

vercel bot commented Apr 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/5cR6R8ofLXV3ZFwj9cznKLcMstME
✅ Preview: https://hds-flight-website-git-spike-button-link-cta-main-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/2zgjNUPYKasbFTv28vmWJWAeTTFq
✅ Preview: https://hds-components-git-spike-button-link-cta-main-hashicorp.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

🦋 Changeset detected

Latest commit: 0ca2179

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hashicorp/design-system-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@didoo didoo requested a review from a team April 21, 2022 07:54
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 20, 2022 09:17 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 20, 2022 09:17 Inactive
@didoo
Copy link
Contributor Author

didoo commented May 20, 2022

@didoo didoo changed the title [WIP] Button/Link/CTA - Proposal Button/Link/CTA - Updates for the interactive elements May 20, 2022
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 20, 2022 10:46 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 20, 2022 10:46 Inactive
@heatherlarsen
Copy link
Contributor

So @heatherlarsen this is intentional. The point is that the link-inline per se doesn't have styling: it inherits from the parent container.

I see you updated it so that it presents visually with the other font styles included, but if you think it'll be easier for engineers to see it without the other styles, I'm all with that too. Was just a gap in understanding for me and I missed the original note. My bad.

@vercel vercel bot temporarily deployed to Preview – hds-components May 24, 2022 09:55 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 24, 2022 09:55 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 25, 2022 21:21 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 25, 2022 21:22 Inactive
didoo added 2 commits May 26, 2022 16:07
# Conflicts:
#	packages/components/addon/components/hds/dropdown/list-item/interactive.hbs
#	packages/components/tests/dummy/app/templates/components/link-to/cta.hbs
#	packages/components/tests/dummy/app/templates/components/link/cta.hbs
@vercel vercel bot temporarily deployed to Preview – hds-components May 26, 2022 15:22 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 26, 2022 15:23 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components May 26, 2022 15:39 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website May 26, 2022 15:40 Inactive
@didoo didoo merged commit 8ad37d1 into main May 26, 2022
@didoo didoo deleted the spike-BUTTON-LINK-CTA-main branch May 26, 2022 18:22
@hashibot-hds hashibot-hds mentioned this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants