-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Button/Link/CTA - Updates for the interactive elements #217
Conversation
(it handles button/a/linkto/linktoexternal)
…ive` generic component
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/5cR6R8ofLXV3ZFwj9cznKLcMstME hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/2zgjNUPYKasbFTv28vmWJWAeTTFq |
🦋 Changeset detectedLatest commit: 0ca2179 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
it was triggering a lint-error: Do not create empty backing classes for Glimmer components ember/no-empty-glimmer-component-classes
…L attribute is used instead of the `@href` Ember argument
…with-link-support
I see you updated it so that it presents visually with the other font styles included, but if you think it'll be easier for engineers to see it without the other styles, I'm all with that too. Was just a gap in understanding for me and I missed the original note. My bad. |
…Interactive` components
adds WCAG conformance info to button documentation
# Conflicts: # packages/components/addon/components/hds/dropdown/list-item/interactive.hbs # packages/components/tests/dummy/app/templates/components/link-to/cta.hbs # packages/components/tests/dummy/app/templates/components/link/cta.hbs
📌 Summary
This is the "feature branch" used to collect in one single place all the changes proposed to the Button/Link/CTA components. For more details about the reasons and rationale why these changes are proposed, please refer to the single PRs and to the RFC document linked below.
The following PRs need to be reviewed and merged in this order:
Once they're all merged (if approved) in this branch, we'll do a final review of the code to make sure we're not missing or forgetting something, and once this PR is approved it can be merged in
main
and the proposed changes officially released.🚧 TODOs
Once all the branches are merged:
Links, Buttons, CTAs...oh my!
block (probably following a similar update in the documentation in Figma)0.12.0
or major =1.0.0
) - notice: this will be a major breaking change from the code perspectiveminor
release🔗 Links
👀 How to review
👉 Review by files changed
Updated documentation pages:
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.