Dropdown::ListItem::Interactive enhancements MAIN
#2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
packages/codemods/transforms/v4/dropdown-list-item-interactive/README.md
Outdated
Show resolved
Hide resolved
zamoore
changed the title
Dropdown::ListItem::Interactive enhancementsDropdown::ListItem::Interactive enhancements MAIN
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
b496f32
to
8725e93
Compare
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
14acd39
to
8725e93
Compare
hashibot-hds
added
packages/components
showcase
and removed
packages/components
showcase
labels
alex-ju
reviewed
Aug 22, 2024
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
961233b
to
42732fb
Compare
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
ff5f688
to
664c515
Compare
LilithJames-HDS
approved these changes
Aug 28, 2024
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
664c515
to
42f6b72
Compare
didoo
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
I haven't reviewed everything, just made sure that the tests of the codemod were covering enough use cases. From what I see now the coverage is good (and I can't think if something extra not covered) so I am approving that part (and defer to the other reviewers to cover the whole PR). Good job (and particularly appreciated that you gave meaningful names to the test files 🙌)
Co-authored-by: Heather Larsen <hlarsen@hashicorp.com> Co-authored-by: Jory Tindall <jory.tindall@hashicorp.com>
zamoore
force-pushed
the
3620-add-yield-to-list-item-interactive
branch
from
d6448ab
to
0c8e4b1
Compare
Merged
|
🎉 nice one @LilithJames-HDS @zamoore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR will enhance the
Dropdown::ListItem::Interactiveby adding a yielding block.🛠️ Detailed description
This PR contains the following previously approved child PRs
🔗 External links
Jira ticket: HDS-3620
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.