Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdown::ListItem::Interactive
enhancements MAIN #2347Dropdown::ListItem::Interactive
enhancements MAIN #2347Changes from all commits
15c5a12
f81ea24
274de89
d9624b3
1a588b0
24c0ea3
00f21eb
4acc6d8
1a6cf43
07c7ac1
0c8e4b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why deprecate
@text
? Doesn't that make this component different from the same named components not in the dropdown?FWIW, I realize there can never be an "icon-only" version of a
dropdown::listitem
, so we don't have to worry aboutaria-label
in this case. So pragmatically, this change is fine from that perspective. However, one of our rather enforced rules was to make components the same as much as possible, and this is a departure from that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you asking about if it differs from
Hds::Interactive
? That component doesn't accept@text
either, so one of the motivators was to make the API the same afaik.