DismissButton, RadioCard::Group, RichTooltip::Toggle - Type safety fixes
#2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glint doesn't seem to be smart enough to recognize composable helpers, so we split the logic to make it happy.
Requires fixing the `HdsFormFieldsetLayoutValues` enum
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-ju
commented
Sep 10, 2024
| @@ -131,10 +132,10 @@ export default class HdsFormField extends Component<HdsFormFieldSignature> { | |||
|
|
|||
| @action | |||
| appendDescriptor(element: HTMLElement): void { | |||
| registerAriaDescriptionElement(this, element); | |||
| registerAriaDescriptionElement(this as AriaDescribedByComponent, element); | |||
There was a problem hiding this comment.
AriaDescribedByComponent is a more generic component signature covering the Field and Fieldset components (both potentially having descriptors, such as HelperText and Error). Their signatures vary in a sense that @layout has different values, so we're doing this casting here to ensure TypeScript that they are matching the more generic type. I couldn't find an alternative, but open to suggestions.
shleewhite
reviewed
Sep 10, 2024
shleewhite
approved these changes
Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
As we converted all our components to TypeScript I did a thorough check and discovered a few instances where glint ignore was not removed:
DismissButton: needed it to be removedRadioCard::Group: removing it revealed a complexity where Field and Fieldset share thelayoutargument, but have different values for them (vertical/flag and vertical/horizontal, respectively)RichTooltip::Toggle: removing it meant the logic needed small adjustments (open to alternatives/suggestions)👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.