Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DismissButton, RadioCard::Group, RichTooltip::Toggle - Type safety fixes #2401

Merged
merged 5 commits into from
Sep 10, 2024
Merged

DismissButton, RadioCard::Group, RichTooltip::Toggle - Type safety fixes #2401

merged 5 commits into from
Sep 10, 2024

Commits on Sep 10, 2024

  1. Remove @glint-nocheck from DismissButton

    @alex-ju
    alex-ju committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a9830f8 View commit details
    Browse the repository at this point in the history

  2. Remove @glint-nocheck from RichTooltip::Toggle 

    Glint doesn't seem to be smart enough to recognize composable helpers, so we split the logic to make it happy.
    @alex-ju
    alex-ju committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    41bd3e3 View commit details
    Browse the repository at this point in the history

  3. Remove @glint-nocheck from RadioCard::Group 

    Requires fixing the `HdsFormFieldsetLayoutValues` enum
    @alex-ju
    alex-ju committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    54ac462 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @alex-ju
    alex-ju committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    efcd09e View commit details
    Browse the repository at this point in the history

  5. Switch from intersection to union type for AriaDescribedByArgs

    @alex-ju
    alex-ju committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6e04e73 View commit details
    Browse the repository at this point in the history