Fix computation error on disclosure utility #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d0634a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
didoo
reviewed
Jul 18, 2022
didoo
approved these changes
Jul 18, 2022
Ember, possibly on certain versions, doesn't support setting and getting a `@tracked` property in the same computation. To avoid this type of errors, we're using an explicit conditional statement to toggle the `isOpen` property.
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure
branch
from
d037db1
to
d0634a6
Compare
Merged
alex-ju
added a commit
that referenced
this pull request
Jul 18, 2022
In #456 I wrongly identified the issue. After managing to replicate the issue locally and testing with hashicorp/cloud-ui#3098 it turns out the racing happens between all the action functions (onFocusOut, onKeyUp) triggering the same `notifyPropertyChange` via `close` in a short amount of time (even shorter in automated tests).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Fix computation error on disclosure utility component
🛠️ Detailed description
Ember, possibly on certain versions (3.2x), doesn't support setting and getting a
@trackedproperty in the same computation. To avoid this type of errors, we're using an explicit conditional statement to toggle theisOpenproperty, so we get the property in a computation and set it in a different one.Sample error:
🔗 External links
Issue raised in Slack
👀 How to review
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.