Fix computation error on disclosure (take 2 π) #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π¦ Changeset detectedLatest commit: 71465b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
2 times, most recently
from
639fb83
to
dddbf0c
Compare
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
dddbf0c
to
093595b
Compare
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
093595b
to
4a39977
Compare
alex-ju
commented
Jul 19, 2022
|
|
||
| export default class HdsDisclosureComponent extends Component { | ||
| @tracked isOpen; // notice: if in the future we need to add a "@isOpen" prop to control the status from outside (eg to have the Disclosure opened on render) just add "this.args.isOpen" here to initalize the variable | ||
| @tracked toggleRef; | ||
| @tracked isToggleClicked; |
There was a problem hiding this comment.
This is a leftover from an old refactoring β not used anywhere across the repo.
didoo
approved these changes
Jul 19, 2022
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
4a39977
to
91ce0da
Compare
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
91ce0da
to
f9b38f4
Compare
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
f9b38f4
to
143b7b6
Compare
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
143b7b6
to
2706b9f
Compare
didoo
reviewed
Jul 19, 2022
alex-ju
force-pushed
the
alex-ju/fix-computation-error-on-disclosure-2
branch
from
2706b9f
to
71465b3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Summary
Fix computation error on disclosure utility component.
π οΈ Detailed description
In #456 I wrongly identified the issue β the solution made the
cloud-uitests pass, but only sometimes. After managing to replicate the failing tests locally and testing with https://github.com/hashicorp/cloud-ui/pull/3098 it turns out the racing happens between the@actionfunctions (onFocusOut,onKeyUp) triggering the samenotifyPropertyChangeviaclosein a short amount of time (even shorter in automated tests). I tried many options to prevent this error from happening in tests without avail. The only solution I could find that prevents tests incloud-uifrom failing intermittently is to move what happens in theclosefunction to the next runloop β hence I'm proposing this to unblock the adoption of this component until a wiser solution may be determined.Preview
Failing/ο¬aky test in HCP consul
Before
After
π How to review
π Review by files changed
Reviewer's checklist:
π¬ Please consider using conventional comments when reviewing this PR.