Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown component, list items #68

Merged
merged 72 commits into from
Mar 29, 2022
Merged

Dropdown component, list items #68

merged 72 commits into from
Mar 29, 2022

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Mar 15, 2022 •
edited
Loading

📌 Summary

If merged, this PR would add the dropdown items to the dropdown component branch.

📸 Screenshots

Current state:
image

🔗 External links

✅ Reviewer's checklist

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ccc571

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 15, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/4neCWjm6xviWSvcWuH36DbjDqanx
✅ Preview: https://hds-flight-website-git-melsumner-dropdown-items-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/4uCU1F4haFZSqab1G6VhGQsreDR6
✅ Preview: https://hds-components-git-melsumner-dropdown-items-hashicorp.vercel.app

@MelSumner MelSumner changed the base branch from melsumner/dropdown-component to melsumner/dropdown-toggle March 16, 2022 19:56
@MelSumner MelSumner changed the base branch from melsumner/dropdown-toggle to melsumner/dropdown-component March 16, 2022 19:57
@vercel vercel bot temporarily deployed to Preview – hds-components March 16, 2022 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 16, 2022 19:57 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 18, 2022 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 18, 2022 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 18, 2022 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 18, 2022 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 18, 2022 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 18, 2022 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 18, 2022 16:55 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 18, 2022 16:55 Inactive
@MelSumner
Copy link
Contributor Author

@didoo I refactored the link color class name (you were right, I had them done incorrectly). I also wrapped the link text and icon in their own divs so we could control icon placement when there is a longer item whose text wraps (see photos).

@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 18, 2022 17:13 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 18, 2022 17:13 Inactive
@didoo didoo mentioned this pull request Mar 18, 2022
Merged
2 tasks
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 21, 2022 13:52 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 28, 2022 17:59 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 28, 2022 17:59 Inactive
@MelSumner MelSumner requested a review from didoo March 28, 2022 18:30
@MelSumner MelSumner marked this pull request as ready for review March 28, 2022 18:30
@MelSumner
Copy link
Contributor Author

ok @didoo I think this one is ready to roll up into the dropdown/component branch with a squash & merge to tidy it all up.

@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 28, 2022 19:15 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 28, 2022 19:15 Inactive
didoo
didoo reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelSumner I have added a bunch of comments. the most critical one is that some merge/conflict was not fixed in the right way and a bunch of code have been lost (the styling of the links for action/critical with all the states)

packages/components/addon/components/hds/dropdown/list-item.js
export const DEFAULT_COLOR = 'action';
export const DEFAULT_ITEM = 'link';
export const COLORS = ['action', 'critical'];
export const ITEMS = ['heading', 'help-text', 'separator', 'copy-item', 'link'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[non-blocker] I am not sure we're going to implement the copy-item in the first release (see comments in #84) so if you want to remove any reference to it in this PR or in the feature branch, is totally OK for me

packages/components/addon/components/hds/dropdown/toggle-overflow.js Outdated Show resolved Hide resolved
packages/components/addon/components/hds/dropdown/toggle-user.hbs Show resolved Hide resolved
packages/components/addon/components/hds/dropdown/toggle-user.hbs Outdated Show resolved Hide resolved
packages/components/addon/components/hds/dropdown/toggle-user.js Outdated Show resolved Hide resolved
packages/components/app/styles/components/dropdown.scss Outdated Show resolved Hide resolved
packages/components/app/styles/components/dropdown.scss Outdated Show resolved Hide resolved
packages/components/app/styles/components/dropdown.scss Outdated Show resolved Hide resolved
packages/components/app/styles/components/dropdown.scss Outdated Show resolved Hide resolved
packages/components/app/styles/components/dropdown.scss Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 28, 2022 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 28, 2022 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 28, 2022 21:12 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 28, 2022 21:12 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 29, 2022 12:39 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 29, 2022 12:39 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 29, 2022 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 29, 2022 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 29, 2022 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 29, 2022 18:46 Inactive
@MelSumner MelSumner requested a review from didoo March 29, 2022 19:03
didoo
didoo approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@didoo didoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair programmed with @MelSumner and fixed all the issues together

@MelSumner MelSumner merged commit 8e3832a into melsumner/dropdown-component Mar 29, 2022
@MelSumner MelSumner deleted the melsumner/dropdown-items branch March 29, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didoo didoo didoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MelSumner @hashicorp-cla @didoo