Refactor "focus-ring" tokens and mixins to support both "active" and "critical" colors #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
The
Dropdown
components has "link" items that have not onlyaction
but alsocritical
colors (see #68 for example).At the moment the "focus-ring" tokens and mixins support only the
action
🛠️ Detailed description
In this PR I have:
Notice: I have bumped the
minor
change for the@hashicorp/design-system-tokens
(despite being a breaking change) and thepatch
change for the@hashicorp/design-system-components
because of the fact that we have not yet released a version1.0.0
of the packages. I'll take care to open a PR for DevDot to update their codebase and take care of the breaking change (just a matter or renaming a classname in a couple of places).📸 Screenshots
👀 How to review
👉 Review commit-by-commit or by files changed (as you prefer)
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.