-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #98 from hashicorp/focus-ring-mixin-refactoring
Refactor "focus-ring" tokens and mixins to support both "active" and "critical" colors
- Loading branch information
Showing
12 changed files
with
152 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@hashicorp/design-system-tokens": minor | ||
--- | ||
|
||
refactored “focus-ring” tokens and CSS helpers to support both “action” and “critical“ colors |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@hashicorp/design-system-components": patch | ||
--- | ||
|
||
refactored the “focus-ring” mixins to support both “action” (default) and “critical“ colors |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
/** | ||
* Do not edit directly | ||
* Generated on Tue, 22 Feb 2022 21:05:19 GMT | ||
* Generated on Fri, 18 Mar 2022 20:06:01 GMT | ||
*/ | ||
|
||
.hds-focus-ring-box-shadow { box-shadow: var(--token-focus-ring-box-shadow); } | ||
.hds-focus-ring-action-box-shadow { box-shadow: var(--token-focus-ring-action-box-shadow); } | ||
.hds-focus-ring-critical-box-shadow { box-shadow: var(--token-focus-ring-critical-box-shadow); } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
/** | ||
* Do not edit directly | ||
* Generated on Tue, 22 Feb 2022 21:05:19 GMT | ||
* Generated on Fri, 18 Mar 2022 20:06:01 GMT | ||
*/ | ||
|
||
.hds-focus-ring-box-shadow { box-shadow: var(--token-focus-ring-box-shadow); } | ||
.hds-focus-ring-action-box-shadow { box-shadow: var(--token-focus-ring-action-box-shadow); } | ||
.hds-focus-ring-critical-box-shadow { box-shadow: var(--token-focus-ring-critical-box-shadow); } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,39 +1,30 @@ | ||
{ | ||
"focus-ring": { | ||
"internal": { | ||
"spread": { | ||
"value": "1", | ||
"type": "size", | ||
"action": { | ||
"internal-box-shadow": { | ||
"value": "inset 0 0 0 1px {color.focus.action.internal.value}", | ||
"private": true | ||
}, | ||
"color": { | ||
"value": "{color.palette.blue-300.value}", | ||
"type": "color", | ||
"external-box-shadow": { | ||
"value": "0 0 0 3px {color.focus.action.external.value}", | ||
"private": true | ||
}, | ||
"box-shadow": { | ||
"value": "inset 0 0 0 {focus-ring.internal.spread.value} {focus-ring.internal.color.value}", | ||
"private": true | ||
"value": "{focus-ring.action.internal-box-shadow.value}, {focus-ring.action.external-box-shadow.value}" | ||
} | ||
}, | ||
"external": { | ||
"spread": { | ||
"value": "3", | ||
"type": "size", | ||
"critical": { | ||
"internal-box-shadow": { | ||
"value": "inset 0 0 0 1px {color.focus.critical.internal.value}", | ||
"private": true | ||
}, | ||
"color": { | ||
"value": "{color.focus.action.external.value}", | ||
"type": "color", | ||
"external-box-shadow": { | ||
"value": "0 0 0 3px {color.focus.critical.external.value}", | ||
"private": true | ||
}, | ||
"box-shadow": { | ||
"value": "0 0 0 {focus-ring.external.spread.value} {focus-ring.external.color.value}", | ||
"private": true | ||
"value": "{focus-ring.critical.internal-box-shadow.value}, {focus-ring.critical.external-box-shadow.value}" | ||
} | ||
}, | ||
"box-shadow": { | ||
"value": "{focus-ring.internal.box-shadow.value}, {focus-ring.external.box-shadow.value}" | ||
} | ||
} | ||
} |
7fe1ac1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
hds-components – ./
hds-components-git-main-hashicorp.vercel.app
hds-components.vercel.app
design-system-components-hashicorp.vercel.app
hds-components-hashicorp.vercel.app
7fe1ac1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
hds-flight-website – ./
hds-flight-website-git-main-hashicorp.vercel.app
hds-flight-website-hashicorp.vercel.app
flight-hashicorp.vercel.app