sdk/client: the Content-Length header should be set for DELETE/PATCH requests
#448
Conversation
…H requests too, and match the size of the payload
| // Ensure the Content-Length header is set for methods that define a meaning for enclosed content, i.e. POST and PUT. | ||
| // https://www.rfc-editor.org/rfc/rfc9110#section-8.6-5 | ||
| if strings.EqualFold(req.Method, http.MethodDelete) || strings.EqualFold(req.Method, http.MethodPatch) || strings.EqualFold(req.Method, http.MethodPost) || strings.EqualFold(req.Method, http.MethodPut) { | ||
| req.Header.Set("Content-Length", fmt.Sprintf("%d", contentLength)) |
There was a problem hiding this comment.
looks like this header is being stripped out when it's explicitly set to a 0 value, setting this (and the original logic) fails when it's set to 0, but this works fine if another header is used
There was a problem hiding this comment.
It seems like the stripping of the Content-Length and Transfer-Encoding headers is due to hashicorp/go-retryablehttp#194 - neither of these headers need to be (or should be) manually set in the Header field, they are determined by net/http as part of the transport handling for HTTP/1.1 and HTTP/2.0. Accordingly, I think we should stop trying to set them manually (since it has no effect anyway due to them being automatically replaced by net/http) and wait for hashicorp/go-retryablehttp#194.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Gonna close this out in favor of #500 now that the bug is resolved upstream |
and match the size of the payload