Bugfix: resolve absent Content-Length / Transfer-Encoding headers for HTTP/2 PUT / POST requests
#500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manicminer
added
bug
With hashicorp/go-retryablehttp v0.7.4, the Content-Length header should be set implicitly by net/http in the case of PUT/POST requests that have no body Setting the `Content-Length` and/or `Transfer-Encoding` headers has no effect for http.Request as both these headers are built at send time.
manicminer
force-pushed
the
bugfix/content-length-header
branch
from
83cf986 to
69ece91
Compare
tombuildsstuff
approved these changes
Jun 7, 2023
tombuildsstuff
added
the
release-once-merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content-LengthheaderRef: hashicorp/go-retryablehttp#194
Supercedes: #448