Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: move patent-protected code to another repo #73

Closed
AkihiroSuda opened this issue Nov 13, 2020 · 7 comments
Closed

Request: move patent-protected code to another repo #73

AkihiroSuda opened this issue Nov 13, 2020 · 7 comments

Comments

@AkihiroSuda
Copy link

Could you move patent-protected code (#31) to another repo?
I don't want to import a patent-protected module, even when the functions in the problem are not called actually.

@TBBle
Copy link

TBBle commented Nov 15, 2020

The MPL-2.0 includes a grant of patent rights, but that assumes the contributor of the code (or hashicorp) has the rights to that patent sufficient to grant those rights in the first place.

@AkihiroSuda
Copy link
Author

@armon Could you consider this? Thanks 🙏

@AkihiroSuda
Copy link
Author

@jefferai Could you take a look? 🙏

AkihiroSuda added a commit to AkihiroSuda/golang-lru that referenced this issue Nov 15, 2022
This commit ensures that the patented files are not compiled in,
so that consumers do not need to validate that the patented files are
not actually used.

Consumers can still opt-in to use the patented files by copying them.

Fix hashicorp#31
Fix hashicorp#73

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Author

BrandonWeng added a commit to sei-protocol/sei-cosmos that referenced this issue Feb 3, 2023
## Describe your changes and provide context
IRRC we had discussions around bumping the limit for the inter-block
cache since 1k is pretty little for our volume of TXs per block. Im
setting it to 100k to be the same as the BoundedCacheKv store

While I was investigating the race condition issue in the LRU cache, I
saw that several repos brought up concerns around using ArcCache in
their code as it's been patented by IBM (and later sold to Intel)

hashicorp/golang-lru#31 
hashicorp/golang-lru#73 

ipfs/kubo#6590
ipfs/go-ipfs-blockstore#20

Postgres and IPFS replaced it with 2Q, which based on the whitepaper
should have the same performance as ARC.
## Testing performed to validate your change
Deployed a LT cluster with these changes and saw no impact to consensus
and the performance (with LT clients running) is similar

![image](https://user-images.githubusercontent.com/18161326/216499319-be5ae693-242f-453c-8073-414bf5f810bd.png)
codchen pushed a commit to sei-protocol/sei-cosmos that referenced this issue Feb 12, 2023
## Describe your changes and provide context
IRRC we had discussions around bumping the limit for the inter-block
cache since 1k is pretty little for our volume of TXs per block. Im
setting it to 100k to be the same as the BoundedCacheKv store

While I was investigating the race condition issue in the LRU cache, I
saw that several repos brought up concerns around using ArcCache in
their code as it's been patented by IBM (and later sold to Intel)

hashicorp/golang-lru#31 
hashicorp/golang-lru#73 

ipfs/kubo#6590
ipfs/go-ipfs-blockstore#20

Postgres and IPFS replaced it with 2Q, which based on the whitepaper
should have the same performance as ARC.
## Testing performed to validate your change
Deployed a LT cluster with these changes and saw no impact to consensus
and the performance (with LT clients running) is similar

![image](https://user-images.githubusercontent.com/18161326/216499319-be5ae693-242f-453c-8073-414bf5f810bd.png)
@jefferai
Copy link
Member

jefferai commented Jun 6, 2023

Would it be sufficient for it to be in this repository but a separate go module?

@AkihiroSuda
Copy link
Author

Would it be sufficient for it to be in this repository but a separate go module?

Yes, thanks

@jefferai
Copy link
Member

jefferai commented Jun 6, 2023

Done. See v2.0.3 release notes.

@jefferai jefferai closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants