-
Notifications
You must be signed in to change notification settings - Fork 69
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[store] bump CommitKVStoreCache limit and switch to 2Q from arc (#152)
## Describe your changes and provide context IRRC we had discussions around bumping the limit for the inter-block cache since 1k is pretty little for our volume of TXs per block. Im setting it to 100k to be the same as the BoundedCacheKv store While I was investigating the race condition issue in the LRU cache, I saw that several repos brought up concerns around using ArcCache in their code as it's been patented by IBM (and later sold to Intel) hashicorp/golang-lru#31 hashicorp/golang-lru#73 ipfs/kubo#6590 ipfs/go-ipfs-blockstore#20 Postgres and IPFS replaced it with 2Q, which based on the whitepaper should have the same performance as ARC. ## Testing performed to validate your change Deployed a LT cluster with these changes and saw no impact to consensus and the performance (with LT clients running) is similar ![image](https://user-images.githubusercontent.com/18161326/216499319-be5ae693-242f-453c-8073-414bf5f810bd.png)
- Loading branch information
1 parent
c120d32
commit 1d173a5
Showing
3 changed files
with
6 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters